commit 15f624ec5388c3774b2d1ed4fca6b5f8213b6fbd
Author: Oliver Smith <osmith@sysmocom.de>
Date: 2019-01-17 12:59:56 +0100
docs: running: s/OsmoBTS/OsmoHLR
Change-Id: Ib4e1c8460dbe0a9b7dca8d2291a5e6c5406180e7
commit d4e0e4d503411a24cd993d8494dcfae5acc497ad
Author: Oliver Smith <osmith@sysmocom.de>
Date: 2019-01-17 11:02:32 +0100
docs: running: same argument order as osmo-hlr -h
Change the Synopsis and Options sections of the Running OsmoHLR chapter
to list the arguments in the same order as osmo-hlr. This makes it
easier to compare, which options are already documented, and which ones
are missing.
A follow-up commit will document the missing -U/--db-upgrade option.
Change-Id: If866124e9cfb43c6986d458712961713541e03b6
commit 2dc7d960a1107600f3db9350fe918328dc1b23a6
Author: Oliver Smith <osmith@sysmocom.de>
Date: 2019-01-15 14:14:51 +0100
Cosmetic: fix arg desc of db_subscr_update_msisdn_by_imsi()
Properly note that NULL can only be passed as msisdn, not imsi in that
function.
Change-Id: I19b6ad0cf6e9a4bfa9bffa447ebfc7bd1bcac361
commit 52c4aa09b27e23cc8c7d71fc221e6dc914d5bc13
Author: Oliver Smith <osmith@sysmocom.de>
Date: 2019-01-15 13:17:16 +0100
gitignore: add tests/hlr_vty_test.db*
Ignore files generated from the VTY test.
Change-Id: I8f55f655fd6694ac9db7e6280670d16fad61ee72
commit 66106c0992a403cb3ca38b09cd40b4ba4c39b7ca
Author: Oliver Smith <osmith@sysmocom.de>
Date: 2019-01-09 12:05:15 +0100
Cosmetic: hlr.c: remove confusing indent below if
Remove a misleading block in rx_upd_loc_req() around the call to
lu_op_tx_insert_subscr_data(). At least for me, this made the block look
like it belonged to the if statement above (which has no brackets),
before I looked more closely at it.
Change-Id: I96d3ba4108f4811279caf088a9179afce24e8112
commit 783ac81b9caa629b82b4d47dd6be704f8670dced
Author: Oliver Smith <osmith@sysmocom.de>
Date: 2018-12-17 11:34:51 +0100
Reply to CHECK-IMEI GSUP messages
Decode the IMEI from incoming CHECK-IMEI messages, print the IMEI to
the log and always send ACK back to the VLR/MSC.
In the future, we will not only log the IMEI, but store it in the HLR
(OS#2541). This is not the original intention of CHECK-IMEI from the
3GPP spec, but an useful side effect.
Depends: I085819df0ea7f3bfeb0cabebb5fd1942a23c6155 (libosmocore)
Related: OS#3733
Change-Id: Ib240474b0c3c603ba840cf26babb38a44dfc9364
commit df8d454919e9482e5eaa823df4b495cdcc620c1d
Author: Vadim Yanitskiy <axilirator@gmail.com>
Date: 2018-11-29 01:49:57 +0700
gsupclient: introduce osmo_gsup_client_enc_send()
Several parts of OsmoMSC (e.g. GSM 04.11, 09.11, etc.) are dealing
with GSUP message encoding and sending towards OsmoHLR. In order
to avoid code duplication, let's have a shared function here.
Change-Id: I0589ff27933e9bca2bcf93b8259004935778db8f
commit 9ea9bbbc7f70f46c17b0c6563cc9c73d6455ec29
Author: Oliver Smith <osmith@sysmocom.de>
Date: 2018-12-06 13:54:54 +0100
contrib: fix makedistcheck with disabled systemd
EXTRA_DIST files need to be distributed, no matter if the systemd option
is configured or not.
Change-Id: Ic164403189510f3b20ff7906df09c78550735591
commit 5c14c9ccca83563d07670eb8e9ed5867ca957112
Author: Stefan Sperling <ssperling@sysmocom.de>
Date: 2018-12-07 12:30:21 +0100
display last location update timestamp in vty
Read the subscriber's last location update timestamp from the
database and display it in the output of 'show subscriber'.
For example:
OsmoHLR> show subscriber id 1
ID: 1
IMSI: 123456789000000
MSISDN: 543210123456789
VLR number: 712
SGSN number: 5952
last LU seen: Fri Dec 7 11:30:51 2018 UTC
While the database stores the timestamp as a string, we
convert the timestamp into time_t for internal use.
This allows for flexible potential use of the timestamp
in contexts other than the VTY in the future.
The timestamp displayed in the VTY is created with ctime_r(3).
It does not match the format of the raw string in the database:
sqlite> select id,last_lu_seen from subscriber;
1|2018-12-07 11:30:51
Related: OS#2838
Change-Id: Ie180c434f02ffec0d4b2f651a73258a8126b2e1a
commit 705b61bcb795490e265027d0b45499b87dd65e12
Author: Stefan Sperling <ssperling@sysmocom.de>
Date: 2018-12-07 12:44:50 +0100
add whitespace around PRId64 constants
Avoid string concatenations without interleaving whitespace.
Some compilers don't like "foo""bar", they only like "foo" "bar".
Requested by: Pau
https://gerrit.osmocom.org/c/osmo-hlr/+/12121/5/src/db_hlr.c#637
Change-Id: Ic7a81114f9afbefcbd62d434720854cfdd4a2dd9
commit 638ba8cc049b35c1a6a604fb058a92cff68198e1
Author: Stefan Sperling <ssperling@sysmocom.de>
Date: 2018-12-04 15:07:29 +0100
store a timestamp of the last location update seen from a subscriber
Timestamps are stored in the HLR DB in the new 'last_lu_seen' column
of the 'subscriber' table, in UTC and in granularity of seconds.
At present, osmo-hlr only records these timestamps but otherwise
makes no use of them. Because the timestamps are stored in a
human-readable form, they may already provide value to external
processes which need this information. For example:
sqlite> select imsi,last_lu_seen from subscriber;
901990000000001|2018-12-04 14:17:12
I didn't bother adding additional tests because the code added
with this commit is already being exercised by several calls
to db_subscr_lu() in db_test.c.
This change requires a HLR DB schema update. Existing databases
won't be upgraded automatically. However, osmo-hlr will refuse
to operate with databases which are not upgraded.
Change-Id: Ibeb49d45aec18451a260a6654b8c51b8fc3bec50
Related: OS#2838
commit 55f5efa5681fe7456d0c7adbee324dbeff2a283e
Author: Stefan Sperling <ssperling@sysmocom.de>
Date: 2018-12-04 11:40:30 +0100
introduce osmo_gsup_client_create2()
Add a new API which allows creating a GSUP client connection with
more identification information than just a unit name. Instead of
being selective about which idenfifiers callers may use, allow
callers to pass a full-blown struct ipaccess_unit. This allows
applications to use entirely custom identifiers on GSUP client
connections.
This change is a prerequisite for inter-MSC handover because MSCs
will need to use unique identifiers towards the HLR, which isn't
very easy to do with the old osmo_gsup_client_create() API. While
it's always been possible to pass a unique unit_name, this is not
as flexible as we would like.
The old API remains for backwards compatibility.
struct osmo_gsup_client grows in size but is allocated internally
by the library; old calling code won't notice the difference.
Change-Id: Ief09677e07d6e977247185b72c605f109aa091f5
Related: OS#3355
commit e6ce52bbdeb1dff729debb68313504ab07ee00a6
Author: Vadim Yanitskiy <axilirator@gmail.com>
Date: 2018-12-01 00:16:44 +0700
SS/USSD: fix: properly (re)schedule NCSS session timeout
It may happen that either the MS or an ESME would become
unresponsive, e.g. due to a bug, or a dropped message. This
is why we have SS session timeout, that prevents keeping
'stalled' sessions forever.
For some reason, it wasn't properly resceduled in case of
subsequent SS/USSD activity, so the lifetime of a session
was limited. Let's properly (re)schedule it.
Change-Id: I11aeacf012b06d3d0b5cc6e64baecf857b645fda
Related: OS#3717
commit d157a56361c9b42bc63dc998183b2c4471a5ef04
Author: Vadim Yanitskiy <axilirator@gmail.com>
Date: 2018-12-01 00:03:39 +0700
SS/USSD: make NCSS session timeout configurable
It may happen that either the MS or an ESME would become
unresponsive, e.g. due to a bug, or a dropped message.
This is why we have SS session timeout, that prevents
keeping 'stalled' sessions forever.
Let's introduce a VTY option, which can be used to configure
this timer (by default it's set to 30 seconds):
hlr
...
! Use 0 to disable this timer
ncss-guard-timeout 30
Change-Id: I971fc2cee6fd46d4d5d6dac6c634e0b22fff183d
Related: OS#3717
commit 9c8806acf537fec0cec279da19185e857ac39470
Author: Vadim Yanitskiy <axilirator@gmail.com>
Date: 2018-11-30 08:11:19 +0700
SS/USSD: release IUSE sessions immediately after response
At the moment, all available IUSE handlers do assume a single
request-response operation, e.g. MS requests its MSISDN - IUSE
responds. No further nor intermediate communications is required.
Let's immediately terminate such SS sessions in order to avoid
waiting for the session inactivity watchdog (i.e. timeout).
Change-Id: Iaefe37512da79e10fbe92378236bfff0eae0f8b9
commit 4b8be4d12d2d9c6ffabc85f23e7239393c9a05fc
Author: Oliver Smith <osmith@sysmocom.de>
Date: 2018-11-28 14:57:25 +0100
contrib/jenkins.sh: build and publish manuals
Add new environment variables WITH_MANUALS and PUBLISH to control if
the manuals should be built and uploaded. Describe all environment vars
on top of the file.
When WITH_MANUALS is set, install osmo-gsm-manuals like any other
dependency and add --enable-manuals to the configure flags (for "make"
and "make distcheck"). Add the bin subdir of the installed files to
PATH, so osmo-gsm-manuals-check-depends can be used by ./configure.
Related: OS#3385
Change-Id: Ia1a6ab64c7912f30a693ca4f5f474f22d72b8873
commit bc9bead62afb31844e80d5a8813abcd9ad82a6f7
Author: Oliver Smith <osmith@sysmocom.de>
Date: 2018-12-04 14:18:23 +0100
Fix DISTCHECK_CONFIGURE_FLAGS override
Set AM_DISTCHECK_CONFIGURE_FLAGS in Makefile.am instead of
DISTCHECK_CONFIGURE_FLAGS. This is the recommended way from the
automake manual, as otherwise the flag can't be changed by the user
anymore.
Related: OS#3718
Change-Id: I62a0c0e9cb384f8909229e153ade5567328e5c61
commit 4655e6f1fe91676df5f9a6946feca54ac87b5fe2
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-12-04 14:13:47 +0100
Rename db_bootstrap.sed to db_sql2c.sed
Side effect of the db schema patch, now a mere cosmetic change.
Change-Id: I47a101e3b76b2125d786f22bf100604cf5e8eb40
commit 8f3a7cce80955082daeb4372472a6dd94035200a
Author: Stefan Sperling <ssperling@sysmocom.de>
Date: 2018-11-27 12:10:45 +0100
add database schema versioning to the HLR database
Make use of pragma user_version to store our database schema version.
The present schema is now identitifed as 'version 0', which is also
the default value for databases on which we never ran the statement
'pragma user_version' before.
Only bootstrap the database if it hasn't been bootstrapped yet.
Previously, bootstrap SQL statements ran every time osmo-hlr
opened the database, and any errors were being ignored in SQL.
Instead, we now first run a query which checks whether tables
already exist, and only create them if necessary.
This change will allow future schema updates to work properly.
Prepare for future schema upgrades by adding a new command-line
option which enables upgrades. This option defaults to 'false'
in order to avoid accidental upgrades.
Change-Id: I8aeaa9a404b622657cbc7138106f38aa6ad8d01b
Related: OS#2838
commit a820ea1f67bab68136fbaae0108bb90c94b77b22
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-12-02 19:46:46 +0100
implement removal of MSISDN
Add the first "official" way to remove the MSISDN from a subscriber entry, to
go back to 'MSISDN: none' like just after 'subscriber create'.
Add VTY command 'subscriber <ID> update msisdn none' to drop the MSISDN from
the subscriber. (Like 'subscriber <ID> update aud3g none')
Add DB_STMT_DELETE_MSISDN_BY_IMSI.
In db_subscr_update_msisdn_by_imsi(), allow passing a NULL msisdn, and if NULL,
call above delete SQL statement.
Change-Id: I15419105ea461137776adb92d384d8985210c90e
commit 8aa780bf80fa4ffde8a5df9d8b87a2e919193f1f
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-12-02 18:52:49 +0100
add 'show subscriber' command, alias for 'subscriber ... show'
When I wrote the osmo-hlr subscriber command, I failed to heed the common
'show foo' scheme and instead created a 'subscriber [...] show' command.
Relieve that weirdness by creating an alias that has 'show' at the start.
Arrange string macros so that the 'show subscriber' cmd doesn't end in a space
(the SUBSCR macro ends in a space ' ' to implicitly include the space to
commands like 'create', 'show', 'update').
Add the new command to test_nodes.vty and test_subscriber.vty.
Change-Id: I01ce9b0868302d40ed05c6a588316a194d6071e4
commit f08da2459b53c554b866e64a6d6f6282fa836842
Author: Oliver Smith <osmith@sysmocom.de>
Date: 2018-11-14 10:47:01 +0100
build manuals moved here from osmo-gsm-manuals.git
Moved to doc/manuals/, with full commit history, in preceding merge commit.
Now incorporate in the build system.
Build with:
$ autoreconf -fi
$ ./configure --enable-manuals
$ make
Shared files from osmo-gsm-manuals.git are found automatically if
- the repository is checked out in ../osmo-gsm-manuals; or
- if it osmo-gsm-manuals was installed with "make install"; or
- OSMO_GSM_MANUALS_DIR is set.
Related: OS#3385
Change-Id: I52b7b06fddd77c6dc272004f434e9e7651f6b349
commit 62ce834fbf0fb64244dfea3386294cbbd9dfe6fa
Merge: e66e525 bf6b4eb
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-11-27 18:01:37 +0100
Merge history from osmo-gsm-manuals.git
Change-Id: I175d694bea8f0be4edb2be75de780dee82469849
commit bf6b4eb0b9a17059f7c526e4bab6fe76ce61676c
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-11-05 03:18:46 +0100
hlr: update vty reference
Change-Id: I5a2322c0488cb36b089303bbfec5d4db18c41099
commit 79efdf347428fbab4518df0981aee4750b261bb2
Author: Daniel Willmann <daniel@totalueberwachung.de>
Date: 2018-10-23 18:17:28 +0200
OsmoBSC/HLR/MSC: Fix default config file name
Mention that the default is not openbsc.cfg, but osmo-*.cfg
Change-Id: I139e6004e28d6f918f31792e634214a6153edd0e
commit b41394a700f32f263d140712a7e42205d05d5f91
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-08-06 22:18:33 +0200
hlr: Add chapter on USSD configuration
Change-Id: Ie5196ece9f340303bcb4868e3333a9698e28c3d0
commit 0c331abdbc6dc2de2d6a852568bbde8cc0d2ab3a
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-07-02 15:12:33 +0200
hlr: clarify that aud_3g also applies to 2G
(and tweak wording)
Related: OS#3091
Change-Id: I2ae03625ccc1364f953db0611e9a29d935dab803
commit 25e716c849c45e0d0bb194a4e69faec591d8af60
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-03-17 14:15:38 +0100
vty-ref: Update URI of docbook 5.0 schema
... to match the /etc/xml/catalog file on debian (no "www" in hostname)
Change-Id: Id9f3579c7f2bc3af13fe30b5268f249b6f59ed0d
commit 92e49ef3634866e2c9b98f00644d027587c9770d
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-03-06 15:13:25 +0100
OsmoHLR: update vty reference
Add new (generic) logging commands, talloc context print commands.
Add the jitter buffer logging category.
Remove the common commands from the individual sections.
Change-Id: I8e92c821b26908d4baa37745c57b9e15bda2a373
commit 95380ab0371d3e82e18f92ee70ab03d73da67220
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-01-26 11:16:45 +0100
share chapters/gsup.adoc from OsmoSGSN to OsmoMSC + OsmoHLR
Since the NITB split, GSUP is used in all three network elements, so
make the protocol a shared chapter
Change-Id: Id2d7c27ef16eb0ebe5f60d625a1fcf42f1603f4f
commit 849bfd0bef211da28e5a7047402c440af4f80a13
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2017-12-07 17:32:07 +0100
OsmoHLR: update section 'Bootstrap the Database'
Change-Id: I1b7b99cc77d8cd8cce42e7cf93f5e2cd3c2344db
commit 7e2d3c7f4cf2dbfa677f6db17a7ada5131debf77
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2017-10-24 15:47:12 +0200
OsmoHLR: update ctrl description and examples
The patch to refactor ctrl commands to osmo-hlr, change
I98ee6a06b3aa6a67adb868e0b63b0e04eb42eb50, was tweaked. Adjust accordingly.
Change-Id: Ie4da6115bb2eb005a9f95bf4de1bfe36468fd607
commit 8f725ae6556902f19239ee1e76679e66a26a0549
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2017-10-24 14:31:13 +0200
OsmoHLR: add make target to update the example ctrl and vty files
Change-Id: I88027396ec15101697a79aa5e964387d47abdae2
commit 1ed4bb4ff1d22f5f4a5c6385fa0ae29b1411a049
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2017-10-19 05:11:57 +0200
refactor Makefile build rules, don't use the FORCE
The initial goal was to make sure we don't have overall FORCE rules causing
unnecessary rebuilds -- annoying while writing documentation. As I looked
through possible dependencies, I finally understood what's going on here.
Remove code dup and nicely sort which belongs where in build/Makefile.*.inc. In
each, describe in a top comment how to use it, and also unify how they are
used:
- Rename Makefile.inc to Makefile.docbook.inc and refactor
- Add Makefile.vty-reference.inc
- Add Makefile.common.inc
Make sure that we accurately pick up all dependencies.
Drop use of the macro called 'command', that silenced the actual command lines
invoked and replaced them with short strings: it obscures what is actually
going on and makes the Makefiles hard to read and understand.
Each manual's makefile is greatly reduced to few definitions and a Makefile
include, e.g. one for asciidoc, one for VTY reference.
Move common/bsc_vty_additions.xml to OsmoBSC/vty/libbsc_vty_additions.xml, link
from OsmoNITB. It applies only to OsmoBSC and OsmoNITB.
Add a script that combines a VTY reference file with *all* additions files
found in a manual's vty/ dir. Call this from Makefile.vty-reference.inc.
Change-Id: I9758e04162a480e28c7dc83475b514cf7fd25ec0
commit 25dd7851577478848e8224758520c9e18dfd3780
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2017-09-25 16:37:34 +0200
add OsmoHLR manual, OsmoHLR VTY reference
Change-Id: Ieb6a362a26a7e65199f68f5cd32d9b6b0e5d0fbf
commit 4f5f6f83f389a2f91d64913aea31190a42fadc73
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-11-27 17:59:14 +0100
Importing history from osmo-gsm-manuals.git
Change-Id: I2907e34a3bdba41142ffd4be43ce0e3e9a86aa42
commit e66e525e0904c234a17416aeee0393779d6e1bf3
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-09-28 02:59:19 +0200
fix and re-enable osmo_hlr_subscriber_update_notify()
Send updated subscriber data out to exactly those GSUP clients that match the
last LU operations (depending on each client sending distinct identification).
As this adds logging on DLGSUP, also change adjacent GSUP related logging from
DMAIN to DLGSUP.
Related: OS#2785
Change-Id: I7c317de8329d9a115d072fc61ddb9abc21b7e8d8
commit 4a4bdcdf9757e3935499ce11c2c902097cd39776
Author: Vadim Yanitskiy <axilirator@gmail.com>
Date: 2018-10-12 21:44:07 +0200
hlr_ussd.c: fix: reject 'structured' SS requests
As we don't store any SS related information (e.g. call forwarding
preferences) in the database, we don't handle 'structured' SS
requests at all. Let's reject them by sending error message
with FACILITY_NOT_SUPPORTED code.
Change-Id: Ia1317c5d372a42473cce65c0c985103e43be77fd
Related: OS#3651
commit cb364bb429b7d188367e445a2bd2b9d81e416d54
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-09-28 01:22:15 +0200
store gsup peer upon accepting LU
Store the GSUP client's IPA_IDTAG_SERNR in vlr_number or sgsn_number (depending
on is_ps), just before sending the Insert Subscriber Data message after a
successful LU Req. Log about it.
Original patch: Ib2611421f3638eadc361787af801fffe9a34bd8a by laforge
Related: OS#2796
Change-Id: If438664faa5d68404f465f8b2002c6d03bbf3ceb
commit d646207553e3e8a32935ec1cf247f6044c480121
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-09-28 01:22:15 +0200
more space for vlr_number and sgsn_number
To be able to handle our 20 chars long IPA tags, enlarge the vlr_number and
sgsn_number storage in struct hlr_subscriber.
Technically, osmo-hlr should be able to store any type of Global Title, blob of
arbitrary size. For our purposes, 32 is enough for now.
Related: OS#2796
Change-Id: I0121f1c4dbda3a076d780a3834281b21dab85493
commit 6cee799d5e7d1f19e30424f2411a79e21381754a
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-09-28 02:53:22 +0200
fix is_ps logic in rx_upd_loc_req(), store CS as is_ps = false
A missing 'else' in rx_upd_loc_req() causes *all* clients to be indicated as
is_ps=true regardless of the GSUP CN Domain IE that was received.
Replace that odd if cascade with a switch() that fixes the flawed logic. Hence
osmo-hlr now correctly indicates each client's is_ps, iff the client sends CN
Domain IEs in GSUP LU Request messages.
Related: OS#2796, OS#3601
Change-Id: I2c5fa9f5cae25cfd66afbf088303edff7d045a00
commit c88bdab96dbb2786ddecb1f11ee2973eb9248265
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-09-26 09:18:13 +0200
fix VTY tests to expect well-formed output of logging configuration
In libosmocore Change-Id Ia75c7067284ea225cffe13ca71bad05a7747ae66
we fixed the generation (saving) of logging configuration to use
one level of indent, rather than the previous broken implementation
with two levels of indent. This means we have to adjust the VTY
test expectations here.
Change-Id: I9282a59bbfad4cfc86e86c1212c74cccfe187ff8
commit 607ce5ca931fb5766c4a0e6e4ed857eca0124d4c
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-09-25 20:34:25 +0200
osmo-hlr.cfg: Ensure well-formed config file example
Change-Id: I136fdda6f4088f2e8094eed6fe9481f5d6476d4f
commit ccdb970c5766b9cc8e62a1e7d6fbdfe2339396c5
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-09-18 15:05:17 +0200
make: always allow running python tests manually
Keep the rules to run the external-tests in tests/Makefile available for
invocation, to allow conveniently launching the tests manualy without the need
to pass --with-external-tests to ./configure first.
Change-Id: Ic28dbeabddee6b41af12b977e3fe59e663ee51a1
commit a5b36a09044768e8c7db3f0670af8321259f7402
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-09-13 18:22:24 +0200
tweak example config
Remove 'logging level all' setting.
Tweak some more logging details (to my current favorite).
Add USSD example for showing the IMSI.
Change-Id: I8296832704d779df5f1b20a595b568c99780e64d
commit 13000d8d142cb8c9d03b993db18e9d47d78ddc1f
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-09-13 18:13:57 +0200
fix build: adjust test_nodes.vty to logging change
Since libosmocore
commit eb9284ba577d338f74653fcf09ebca0c397823eb
Change-Id I36f17c131cc70ce5a1aef62fd9693097de230cd4
"logging vty: deprecate 'all', introduce 'force-all'"
,
'logging level all' is replaced by 'force-all'.
Adjust the test script to not expect 'logging level all'.
While at it, remove some more expectations that aren't important.
Change-Id: Ia170f8416ebb60c499d2536078f43f28b61d0554
commit 7ebfd065dac1bfcce186ec99da256afd1b249c1c
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-09-12 18:20:42 +0200
Install sample cfg file to /etc/osmocom
Change-Id: I2ac73f426d9489fcd64c2eea547eb1f3ec26ae2c
commit 966fcb2ca8d2021b8337b89ae92292bf93848598
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-09-12 18:15:03 +0200
Move doc/Makefile.am to doc/examples/Makefile.am
Change-Id: I89ef3abe86e7ceb7b389ac1cb227ea065bfbce37
commit 6fe1c2220ad8a6d7d61af487b43adb11a21b79cb
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-09-10 12:27:21 +0200
Install systemd services with autotools
Change-Id: Id81ae8e2d8a2c9456ac0dac2c30c0d24dab3b694
commit 0da9f2f19cce314b3878ed35859c007e435316c7
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-08-13 20:42:36 +0200
libosmo-gsup-client: License is GPLv2-or-later
Fix the unintentional AGPLv3-or-later license header in gsup_client.c
Change-Id: I6378bd59fdbe8d95cd6132a1cbc40ae29b558c42
commit 1eb9869d81cc1e94c990b753c9aadfac3838686c
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-08-08 08:57:26 +0200
USSD: Fix "ussd default-route"
Before this patch, the default route logic was not implemented. The
user could specify a default-route, but it wouldn't be used by the
actual routing logic. Let's fix that.
Change-Id: I0b04a75dc297f088f13da413d08c52e0747e46e6
commit 3adb33de931c81fe696fdc48b535b54d816c9cfd
Author: Vadim Yanitskiy <axilirator@gmail.com>
Date: 2018-08-03 00:07:54 +0700
hlr_ussd.c: avoid using CR and NL in IUSE responses
According to GSM TS 03.38, section 6.1.2.1, CR symbol at the end
is optional, and moreover libosmogsm encoding API will carry
about the bit padding itself.
Change-Id: I09e8a67758698f3b7a578eab956311e269d091ee
commit 791ea72ee4c6e8aa4915db8172160bb4c2490580
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-08-06 18:35:44 +0200
debian: Make libosmo-gsup-client-dev depend on libosmo-gsup-client0
The -dev package should depend on the binary package.
Change-Id: I01e58788e8485cadecad8b8788887743b41b9f1f
commit 9f7b69a618c7142fecbacea2602cfa38c51f6270
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-08-06 11:57:42 +0200
gitignore: Add .tarball-version
Change-Id: I2ed792ef248e2b62f63acc7d83add240df03336f
commit e6c839ed2d8db3f2f732bc924a334926efdc9e38
Author: Vadim Yanitskiy <axilirator@gmail.com>
Date: 2018-08-02 23:59:51 +0700
hlr_ussd.c: fix: properly print a EUSE / IUSE name
We need to distinguish between both EUSE and IUSE, and properly
print their names. Otherwise, garbage is printed in case of IUSE.
Change-Id: I497e7c1fe41279afdb1256ee69e166066a6462bb
commit b93c44f32e2b21ab58fa98c9cb4bbe63d81269e3
Author: Vadim Yanitskiy <axilirator@gmail.com>
Date: 2018-08-02 23:37:51 +0700
USSD/hlr_vty.c: print error if EUSE is not found
Change-Id: I18045c5e544a99b2414a6f0268f1343df119b9f3
commit a05efe8803f4de430409fd07d00a36686dc05109
Author: Vadim Yanitskiy <axilirator@gmail.com>
Date: 2018-07-31 01:42:25 +0700
hlr_ussd.h: drop meaningless forward declaration
Change-Id: I70a5c7c83c2356b779fb1ea7ffe07ccc1e279c22
commit 764514198bd4a0b5e150f9579cace840b1262233
Author: Martin Hauke <mardnh@gmx.de>
Date: 2018-07-31 20:13:09 +0200
debian: Fix typo in package description
Change-Id: Iaa5a3b9e249ce493221569cf9411cc04c4044a0c
commit 5198609a5e3ef4c77f65dfa69deadb4045631017
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-07-31 19:34:38 +0200
pkg-config: Fix libosmo-gsup-client pkg-config file
Both description and actual "Libs" line were broken.
Change-Id: I92e625418d53a2f17feca87c72624b84183f8cdb
commit 7c2f430fc5583c9e3976a387ab326295808f8882
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-07-31 18:07:18 +0200
debian: Add sub-package for libosmo-gsup-client
Change-Id: Iad227bb477d64da30dd6bfbbe1bd0c0a55be9474
commit 633fddebcdf15c7daa1a9a12cd9a9de050174c01
Author: Vadim Yanitskiy <axilirator@gmail.com>
Date: 2018-07-31 01:43:26 +0700
Update .gitignore: ignore osmo-euse-demo
Change-Id: I1e2fb003d507a00f9255e021dd8956269f0657ee
commit 7c5e930aa8d97a6dfd363031f0e12a407b415a48
Author: Vadim Yanitskiy <axilirator@gmail.com>
Date: 2018-07-31 01:38:40 +0700
hlr_ussd.h: use proper libc headers
Change-Id: I2b9485be08c6cbf188ed1f4059ff28ab65c61dbf
commit 83df3490458ea3e36b6fbedd88e2ebfa810ce3d2
Author: Vadim Yanitskiy <axilirator@gmail.com>
Date: 2018-07-31 01:17:25 +0700
hlr_ussd.h: add #pragma once include guard
Change-Id: Iba9470e11af2f2609486b9b0b6bfa3207b883a3a
commit 05fe0233d246acbbaa2716aeffd850cba29c0f79
Author: Vadim Yanitskiy <axilirator@gmail.com>
Date: 2018-07-30 21:54:17 +0700
tests/Makefile.am: also remove temporary sqlite files
The osmo_verify_transcript_*.py do terminate the osmo-hlr process
in some unusual way, so the database file is not closed properly.
Let's remove temporary files after the tests execution.
Change-Id: I9e4c98e86c1d6b627bfee1acb4fa116460687483
commit 2781bb767efbce3787ae0f52b0163f7ea07ef4e7
Author: Vadim Yanitskiy <axilirator@gmail.com>
Date: 2018-07-30 21:41:44 +0700
Update .gitignore: add missing build products
Change-Id: I71809105c631703477d8226ba28a57121807b5ed
commit f473c7b23cc5e80a953327353a4407fcdde0eea7
Author: Vadim Yanitskiy <axilirator@gmail.com>
Date: 2018-07-30 14:29:39 +0700
hlr_vty_subscr.c: fix subscriber creation command help
Change-Id: Id8dda53cdd10aeedf5451109f9e61d6438c3e09b
commit dab544e14bedb990a3cbcc0df53a97d1bb24e973
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-07-29 16:14:48 +0200
USSD: Add support for internal USSD handlers
There are some requests that are best served inside the HLR, as it
has access to subscriber information such as MSISDN and IMSI.
This unfortunately required quite some restructuring of the USSD
related structures including the VTY syntax for adding routes.
The default config file has been updated to replicate the *#100#
built-in behavior of old OsmoNITB.
Closes: OS#2566
Change-Id: I1d09fab810a6bb9ab02904de72dbc9e8a414f9f9
commit 7d29d59292c5357537665fdf3a1f2022c79ae604
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-07-28 22:00:08 +0200
Add osmo-euse-demo as minimalistic test of a External USSD (EUSE) handler
This is a small program which simply echo's the USSD request message it
gets in a quote back to the sender. Its purpose is to illustrate how
EUSEs can be implemented using libosmo-gsup-client.
Change-Id: I3fb8554ca329cb609c591058254117006f665e73
commit 55d32a1e3c40cc0531a8d810b74fd8d6a77048fe
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-07-30 17:26:35 +0200
USSD: fix null-pointer deref in "default-route" vty/config cmd
Change-Id: I5ebaea77be6beaf88771fb584477358a4d80a47f
commit 95b96d4245e7eb06e92a2261b0f365eb526eab83
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-07-29 12:47:39 +0200
USSD: Add new "DSS" logging category and use it appropriately
Change-Id: I0ac198a49ba70ea40fea18464325f1925797a6e8
commit 9b6bc9e4798b85c141753b185c10ac9b6ee7cf20
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-07-30 17:01:59 +0200
osmo-hlr.cfg: Don't enable DEBUG logging by default
This is not a setting that normal users should use in production.
Change-Id: I6594fb083cad70ec596af872d85f805897b29644
commit 7f32f5f3e67bd8fa254ce26be9fea5a36299a4c6
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-07-29 12:43:49 +0200
USSD: Further unification of log output; Use LOGPSS when possible
Change-Id: I2c508fe70337d24c4a8b48e0393ad3c979eea0e7
commit 7266731eca980fd0df87c6c3cffad05080236102
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-07-29 12:38:09 +0200
USSD: Send ReturnError component if USSD Code unknown / EUSE disconnected
Change-Id: Ieef06cec05dd81f600594465d18804362e0fafd6
commit 97bfb65eebae2182aa91b204af2ce680305074ab
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-07-29 12:28:11 +0200
hlr_ussd: Introduce LOGPSS() macro
Change-Id: I1058ef9fd67af2224c991e43bab02bcf21c9f174
commit bb77939a86260fcd0c6e2c15b5c6f06df8a0b9fe
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-06-16 20:21:10 +0200
USSD: Add basic dispatch + decode of GSUP-encapsulated SS/USSD
We don't want any SS session to run for more than 30s. The timeout
is currently not refreshed.
If we need more comprehensive timeout handling, using osmo_fsm for SS
sessions might make sense.
Change-Id: I5c9fb6b619402d2a23fea9db99590143d85ac11a
commit 4956ae1f7074aca8b9c45dfd29bd6e3bc36c65ae
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-06-15 22:04:28 +0200
USSD: Add Core USSD handling + VTY routing config to HLR
Change-Id: I3cfd7cd401ea32b7e92f1124d129099d9f7dc6e6
commit d5807b8c871aa09d7cd6a729f9efd8af3e15efb1
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-07-29 12:27:41 +0200
hlr: Export + Declare global g_hlr symbol
It is a global variable, and it's sort of bogus if every C file
re-declares it as a static global variable that is assigned to the
same value as the "real" global one during start-up.
Change-Id: I6f3e50f071fb2fbbe58413b4760dc2215055a444
commit 21c14fc7f4eda1648d6681d1ff91ffc53a73dc31
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-07-23 17:54:41 +0200
GSUP: Log GSUP route add/remove
Change-Id: I1768d0b8ee7e2821e40a799c9a1c1d900a7ddc48
commit 050eb1d8036d367e90604dc7fcd6c3d6d9a8ec98
Author: Vadim Yanitskiy <axilirator@gmail.com>
Date: 2018-07-30 20:48:19 +0700
src/db.c: don't ignore the result of db_bootstrap()
Change-Id: I0de3d4c4355c4dee8b832faae347586d1e1b3516
commit dc17e05e28fc23219aa2c03917bcf70a8edb2131
Author: Vadim Yanitskiy <axilirator@gmail.com>
Date: 2018-07-30 20:14:16 +0700
src/db.c: fix: make sure the database is properly closed
Thanks to ASAN, it was discovered that some part of heap
is not released on exit:
==19736==ERROR: LeakSanitizer: detected memory leaks
Indirect leak of 94616 byte(s) in 214 object(s) allocated from:
#0 0x4e05c6 (/home/wmn/osmocom/osmo-hlr/src/osmo-hlr+0x4e05c6)
#1 0x7f9b01061dc6 (/usr/lib/x86_64-linux-gnu/libsqlite3.so.0+0x33dc6)
Indirect leak of 1160 byte(s) in 1 object(s) allocated from:
#0 0x4e097d (/home/wmn/osmocom/osmo-hlr/src/osmo-hlr+0x4e097d)
#1 0x7f9b01061d58 (/usr/lib/x86_64-linux-gnu/libsqlite3.so.0+0x33d58)
SUMMARY: AddressSanitizer: 95776 byte(s) leaked in 215 allocation(s).
After a long investigation, it was figured out that *sqlite never
closes the database* due to 'unfinalized statements or unfinished
backups'.
The problem was in db_bootstrap(), where several statements were
prepared, but not finalized in loop. This was also the reason of
*.db-shm / *.db-wal files remaining after the program is closed,
and the reason of the following message
db.c:77 (283) recovered 18 frames from WAL file *.db-wal
Let's fix this and stop ignoring the result of sqlite3_close().
Change-Id: Ibe620d7723b1947d4f60f820bd18435ad0193112
Related: OS#3434
commit 953d27ce8fa50bdd9d6e2f4f206a177f083690a4
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-07-23 11:11:22 +0200
gsup_client: rename gsup_client_* to osmo_gsup_client_*
As we're moving this to a common/shared library now, we need to use
the osmo_ namespace prefix for symbol names, struct/type names and
constants.
Change-Id: I294f8f96af4c5daa2b128962534426e04909290e
commit ec6915a771deb50e52ee0adbd66b9d96e588f3fb
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-07-23 14:25:33 +0200
import gsup_client.c as new libosmo-gsup-client
This imports the code from osmo-msc 6afef893e17bce67e4d4119acd34d480ed03ba77
with minimal changes to make it compile. Symbol renaming ot osmo_
prefix is done separately in a follow-up patch to have a as-clean-as-possible
import first.
Requires: libosmocore.git Change-Id Ie36729996abd30b84d1c30a09f62ebc6a9794950
Change-Id: Ief50054ad135551625b684ed8a0486f7af0b2940
commit 9fdb85417467d85ab213f5e689b8693ebdb81f7f
Author: Vadim Yanitskiy <axilirator@gmail.com>
Date: 2018-07-30 03:09:22 +0700
hlr.c: track the use of talloc NULL memory contexts
Tracking NULL memory contexts allows one to detect memory chunks
allocated outside the application's root context, which in most
cases are the result of some mistake.
For example, the VTY implementation still uses the NULL context,
so we have to clean up it manually until this is fixed.
At the moment we have at least one chunk allocated outside the
application's root context (excluding the VTY context):
full talloc report on 'null_context' (total 24 bytes in 2 blocks)
struct lookup_helper contains 24 bytes in 1 blocks
Change-Id: I7ea86730e090c06b2a5966ae4d04b8144b1cd20a
commit 4793a7efc34e1e5945b8adc7ee344406db61fd53
Author: Vadim Yanitskiy <axilirator@gmail.com>
Date: 2018-07-30 03:04:34 +0700
hlr.c: free root talloc context on exit
This makes both ASAN and Valgrind happy, because they do expect
all allocated heap chunks to be released on exit.
Change-Id: I7345dec8d06b0b71a859c16132dc0008cfe17cba
commit 527d934807457f1d5a944fd12658e3403b4de772
Author: Vadim Yanitskiy <axilirator@gmail.com>
Date: 2018-07-30 02:42:25 +0700
hlr.c: move deinitialization code from SIGINT handler
There were a few lines of dead code below the osmo_select_main()
loop, while the actual deinitialization code was a part of SIGINT
handler. Let's reanimate this dead zone by moving the code there
and introducing a global 'loop-breaker' variable.
Change-Id: I0e2d673b420193e2bdc1a92377aca542f3a19229
commit 6b274b95fc357d9007b77a87d862dace60409a32
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-07-02 17:47:21 +0200
sql/Makefile: Create empty /var/lib/osmocom directory at install time
Otherwise osmo-hlr is unable to start correctly.
Change-Id: I1233fc9b3dc685561f79a34e1c32c459dc1aa685
commit edca4f88a653cc688bc1c46611a9f0bc880637e2
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-07-02 17:29:38 +0200
sql/Makefile: Install sql files under doc/.../sql subdir
Change-Id: I1c9008d4692412a0cfe39d05216fc9c857cf1e8a
commit b9c1028cb00f829d2e075c6a0fc21e1bdd967bbf
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-07-02 17:27:44 +0200
sql/Makefile: Install hlr_data.sql as example together with hlr.sql
Change-Id: Id4a12252b309f03bb393fa26612c305744e14403
commit 1442e3a3d30297abdf7ca6d17e239b8e4dc36817
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-07-02 17:15:13 +0200
debian: Avoid installing duplicate cfg file in /etc
Change-Id: Ieb25cc8195a2fe7f81b7a39955e0bca5d5c510eb
commit 0b8f054b5f20ff663706aff97ac7025a14fa4fcb
Author: Martin Hauke <mardnh@gmx.de>
Date: 2018-06-21 08:49:16 +0200
sql/Makefile.am: Make docsdir completely configurable
$(docdir) defaults to $(datadir)/doc/osmo-hlr
Change-Id: I77fa16d0edcf88a8e120921504cd088328077836
commit fa7ee333f7eb37cbf78cd6d8371fd320a23d3379
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-06-24 13:20:32 +0200
Add "show gsup-connections" VTY command
This can help with debugging and give operational insight.
Change-Id: I977b4b8cdb36dab42b3d736a28d8b5f17cff04cd
commit 8fbf82b83facc32978826b3d843d85e445472f80
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-06-24 11:27:40 +0200
gsup_router: Use "#pragma once" and add missing #includes
Change-Id: I2cc43ea5846e5b98281efc897252c8dcc3ef5728
commit bd72f1331dba78ef96d4b1efbf1ca0817d19d1bc
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-06-24 11:26:43 +0200
move osmo_gsup_addr_send() declaration from luop.h to gsup_router.h
Change-Id: I33165b7b58bd8c863083ed50ce21e3c032c579f5
commit 32acace8798ae9d496bd83b162abc6757e7e3425
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-06-16 17:07:28 +0200
gsup_server: Add "priv" pointer and make it point to 'struct hlr'
Change-Id: Iada68996b7f4cbdcca92b254ddaf6b88b962e6f1
commit b85f60477fb6d3e797fde7eae9a3124ecaad174d
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-06-15 18:01:14 +0200
disable blind subscriber insertion into every VLR/SGSN
During the attempt to fix OS#2785 in Change-Id
I6a92ca34cdaadca9eacc774bb1ca386c325ba865, we introduced logic that
would blindly insert a subscriber *concurrently* in all VLRs/SGSNs of
the network on any update of the subscriber.
Before that patch, we didn't update the current serving SGSN/VLR,
and after the change we created subscribers in all SGSNs/VLRs, of which
all-1 are not serving the subscriber at that time.
We'll have to go back to the original behavior until a proper fix can
be introduced.
Change-Id: Ibf6f1b21b08560d4d8f41bbe7782d40abf4585f8
Related: OS#3091
Related: OS#2785
commit a1d3b048fb7a8047a9854d29067c44a6b0066ee7
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-06-11 20:28:35 +0200
Return proper GSUP error in case of too short IMSI
This fixes HLR_Tests.TC_gsup_sai_err_invalid_imsi
Change-Id: I4f51abdf44dfc62d7e8792341aad6dafe58923da
Closes: OS#3028
commit f83432c25c840bfe088ae5f3d27114b9085ad73e
Author: Stefan Sperling <ssperling@sysmocom.de>
Date: 2018-05-03 14:26:59 +0200
move creation of insert subscriber data messages to a common function
Move code to create an Insert Subscriber Data message into a common
function which can be shared by hlr.c and luop.c.
As a consequence, we always encode gsup.cn_domain in the corresponding
msgb and must adjust expected output of the 'gsup' test accordingly.
Change-Id: I6a92ca34cdaadca9eacc774bb1ca386c325ba865
Requested-by: neels
Related: OS#2785
commit 78f430102516a970b9899f962d4562ebdb718670
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-05-04 18:41:35 +0200
Bump version: 0.2.0.3-1b8a → 0.2.1
Change-Id: I9c457e9baeb546bfefacacddddd48996902e587a
commit 1b8a1dc00a9965674a93d72f5f042deea546b94a
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-05-04 16:46:47 +0200
add error handling to osmo_gsup_configure_wildcard_apn()
Follow-up to I83d9ef2868bbb01e3f1ddb7920fe735aca172b15 as requested in code review.
Change-Id: Ifcee1e0d275741c1172b208600851861adb13238
commit 9d307ec7ae3dcb8acce91a16eb6ba8fce6e7db10
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-05-04 16:06:32 +0200
add gsup_test to catch OS#3231
Encode an Insert Subscr Data with is_ps == true to trigger the encoding bug
described in OS#3231, i.e. show that it is fixed.
Move osmo_gsup_addr_send() to a separate .c file, so that it can be overridden
in the regression test to just dump the msgb instead.
I used this test to reproduce issue OS#3231, and now that it's here we might as
well keep it, and possibly expand on it in the future.
Related: OS#3231
Change-Id: Id1453351758f3e1a9ff03bd99fefaf51886e77da
...