commit 3cf5229fa0502e759d45e8397b2e7341ab418165
Author: Stefan Sperling <ssperling@sysmocom.de>
Date: 2018-11-21 13:20:15 +0100
fix use of partly initialized struct in tcp test
Properly initialize sockaddr 'name' used by tcp test, and remove
a redundant re-declaration of this variable in a nested scope.
Change-Id: Id6e488308a72be96cca6aa661f088d2c3c67a6a3
Related: CID#188848
commit cf9e5f8c3302b7ac1c7eb63ff2fcb79df0223980
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-10-29 18:32:49 +0100
esme.c: mark switch statement fall-thru for coverity
Change-Id: I2d8f16242b8ddca855fa387ad93f52adf8bcdeec
commit 16ea74c6383c92360f186282ba18f7b9de6cddf2
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-09-17 10:29:10 +0200
debian/rules: Don't overwrite .tarball-version
The .tarball-version file should contain the *source version* uniquely
identifying the git commit, and not the Debian package name.
With https://gerrit.osmocom.org/#/c/osmo-ci/+/10343/ there is a correct
.tarball-version file in the .tar.xz of the nightly source packages.
Related: OS#3449
Change-Id: I30714578bc7fb3cfe333eebec89dc06eb1bbc9fe
commit 6996e5dba9603208609f4604a3b3d59f88c85d90
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-05-03 18:04:11 +0200
Bump version: 1.12.0.20-a637-dirty → 1.13.0
Change-Id: If8b3a91714b4738ace025fc7ccbcf6a8e1190c4b
commit a637c3c9fe5d512b04e7fbf3957702cef5149be3
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-05-03 17:56:02 +0200
src/Makefile.am: Use LIBVERSION variable to set version-info
Same as we do in all other osmocom projects, and osmo-release.mk
expects that variable name.
Change-Id: I9c6ebb9656d6756e8344fd57a246be58b105c419
commit 0cad3b4538710a91881ddbb80424c2d7c62de962
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-03-05 20:52:50 +0100
jenkins.sh: use --enable-werror configure flag, not CFLAGS
Change-Id: Ib09a4aa3167e5dc24d02e3e59307baa6f7ee3f2c
commit 7fb2a408d78857de581d32d32990be833702b854
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-03-05 20:41:40 +0100
configure: add --enable-werror
Provide a sane means of adding the -Werror compiler flag.
Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"',
but that actually *overwrites* all the other CFLAGS we might want to have set.
Maintain these exceptions from -Werror:
a) deprecation (allow upstream to mark deprecation without breaking builds);
b) "#warning" pragmas (allow to remind ourselves of errors without breaking
builds)
As a last configure step before generating the output files, print the complete
CFLAGS and CPPFLAGS by means of AC_MSG_RESULT.
Change-Id: I5280a692eaf8f626523e0fd929d1febaa2859104
commit 8f7946f30a95a45c04ca5eb58650b9b6ec4d7f8e
Author: Martin Hauke <mardnh@gmx.de>
Date: 2018-02-11 15:47:03 +0100
jenkins.sh: output all test logs when 'make check' failed
Assume that cat-testlogs.sh from osmo-ci is installed in
$HOME/osmo-ci/scripts, and call from jenkins.sh upon
'make check' failure.
Change-Id: I73527117283a3a251591af48e2841c9f452f461d
commit 882a759818f2c274e3ff6370e40d2e4621fd6ce0
Author: Martin Hauke <mardnh@gmx.de>
Date: 2018-02-11 10:27:13 +0100
jenkins: Enable parallel build and distcheck
Change-Id: Id41fbcb5a96093eb6c3dc00bcacbd379111ada70
commit f824d867182701acd2febdfe2bf05f3049f7e577
Author: Martin Hauke <mardnh@gmx.de>
Date: 2018-02-11 10:25:56 +0100
binaries/Makefile.am: Fix parallel build issue
This change fixes a parallel building problem, when
submit_multi_resp_test
was being compiled before its libsmpp34 dependency:
make[2]: *** No rule to make target '../binaries/libsmpp34.la',
needed by 'submit_multi_resp_test'. Stop.
make[2]: *** Waiting for unfinished jobs....
For some reason, automake ignores a dependency if the full
path is provided:
$(top_builddir)/binaries/libsmpp34.la
while the relative path solves the problem:
libsmpp34.la
Change-Id: I5a9d7dbd7b992d322ed0d852ebf8ca2252b51a12
commit 4db6fabf66a072df4e91e9baef9a36fd33d5c58c
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-02-09 11:15:08 +0100
debian/control: Fix Vcs-{Browser,Git} URLs
they so far were a copy+paste mistake from libosmocore.
Change-Id: I3da2239d0f093ba1b6706f044c97a307a8dc41bb
commit 4f3ee2add5f9fbd74358bb8d329f569db4e5aee7
Author: Max <msuraev@sysmocom.de>
Date: 2017-12-21 17:07:20 +0100
Enable sanitize for CI tests
Change-Id: Ibf070228e439ddb3be9c6570f963ac0db05d1c9c
commit 7c2232e0ffd8751376d354fb95a86467d68d3bc8
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2017-11-17 01:43:36 +0100
add --enable-sanitize config option
Change-Id: I83c7b16baeffd3b7ae86edf87a9bb4cbb7346609
commit 0f760a64769c63e267532080f476f63a42eda339
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2017-10-27 22:54:05 +0200
jenkins: use osmo-clean-workspace.sh before and after build
See osmo-ci change I2409b2928b4d7ebbd6c005097d4ad7337307dd93 for rationale.
Depends: I2409b2928b4d7ebbd6c005097d4ad7337307dd93
Change-Id: I0030c8662fa87fb589582a3f6bde6ed53e8e3ef9
commit 05bce4cb9e711be3a39ddc1a5fb9eed373166947
Author: Alexander Couzens <lynxis@fe80.eu>
Date: 2017-10-11 07:09:34 +0200
debian/rules: show testsuite.log when tests are failing
Change-Id: If2d8576c5b15fe86419d1c21741f82d4d705bd60
commit 4a82bb9969d98cc3ee4ac7ebe919b3ddc595715b
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-10-04 08:06:42 +0800
Fix 'make distcheck' by adding .version to EXTRA_DISTI
Commit 1648066f1652e758d93393a875b1337a27fc0cf7 introduced
osmocom-style git-version-gen, .version, etc. - but failed
to include .version in the EXTRA_DIST list of files.
Change-Id: If191e82677d851ca486ec78da6643958d05eb5f6
commit 66197717500693ba089e044817bfdf457dc34090
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-09-17 17:05:54 +0200
contrib: Enable -Werror by default
Change-Id: I2a88cdcbf76ea28a30e82836030f894c2152d5ed
commit c63971fab0d67bc52d7fd455529b844009aa8565
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-09-15 20:09:19 +0200
Fix Out of bounds compilation warning in OCTET8
The code in OCTET8 implementation assumes the len is placed inside the
byte preceding the memory buffer, which is true for the defined cases.
However, it creates a compilation warning. Better pass the value
directly from the struct field rather than playing addr games. this way
we also assert we require to explicitly pass the len.
Fixes lots of warning like the one below:
/home/pespin/dev/sysmocom/bin/../git/libsmpp34/src/smpp34_unpack.c: In function ‘smpp34_u
npack’:
/home/pespin/dev/sysmocom/bin/../git/libsmpp34/src/smpp34_unpack.c:147:14: warning: array
subscript is above array bounds [-Warray-bounds]
lenval = *((inst par) - 1);\
^~~~~~~~~~~~~~~~~
/home/pespin/dev/sysmocom/bin/../git/libsmpp34/def_frame/submit_sm.frame:18:2: note: in e
xpansion of macro ‘OCTET8’
OCTET8( instancia, short_message, 254 );
^~~~~~
Change-Id: Id110f4e977c3becdb44cf5492c372e530ea51551
commit cbdde82aca1103db1ed69f29a666f29fdc6b79ba
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-09-15 19:25:52 +0200
bind_receiver_resp_test.c: Fix compilation warning
/home/pespin/dev/sysmocom/bin/../git/libsmpp34/test_pdu/bind_receiver_resp_test.c: In function ‘main’:
/home/pespin/dev/sysmocom/bin/../git/libsmpp34/test_pdu/bind_receiver_resp_test.c:55:58: warning: ‘snprintf’ output
truncated before the last format character [-Wformat-truncation=]
snprintf((char*)b.system_id, sizeof(b.system_id), "%s", "1234567890123456");
^
/home/pespin/dev/sysmocom/bin/../git/libsmpp34/test_pdu/bind_receiver_resp_test.c:55:5: note: ‘snprintf’ output 17
bytes into a destination of size 16
snprintf((char*)b.system_id, sizeof(b.system_id), "%s", "1234567890123456");
Change-Id: I4ec682a5e2ee4d02008a9c86a0a5507792667d0e
commit 43dc9992bcc5335a5aea99ffde5bd634e96714bb
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-09-15 19:17:10 +0200
smpp34_unpack.c: remove unused variable
Fixes compilation warning below:
/home/pespin/dev/sysmocom/bin/../git/libsmpp34/src/smpp34_unpack.c: In function ‘smpp34_unpack’:
/home/pespin/dev/sysmocom/bin/../git/libsmpp34/src/smpp34_unpack.c:232:18: warning: variable ‘l’ set but not used [
-Wunused-but-set-variable]
uint32_t l;
Change-Id: I75baa65b575deec1cc040490f2e76ebb54e46ca7
commit cad0cc552f9956af3fa90d12de443dabe5c7c320
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-09-15 19:15:05 +0200
smpp34_structs.h: Fix truncated output in str_tlv_id
Fixes compilation warning below:
%s’ directive output may be truncated writing between 8 and 33 bytes into a regio
n of size 30 [-Wformat-truncation=]
snprintf(buff, SMALL_BUFF, "%s",
^~
/home/pespin/dev/sysmocom/bin/../git/libsmpp34/src/smpp34_params.c:136:5: note: ‘
snprintf’ output between 9 and 34 bytes into a destination of size 30
snprintf(buff, SMALL_BUFF, "%s",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#define OPERACION( p_tlv_id ) (tlv_id == p_tlv_id)?#p_tlv_id:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#include "def_list/tlv_id.list"
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
"Reserved"
~~~~~~~~~~
#undef OPERACION
~~~~~~~~~~~~~~~~
);
Change-Id: Ie2ba6182eb0cdd98cadb8317aef49141244aa92d
commit fe9f88add068fa08831abe535ee013cbd63adb3a
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-09-15 19:14:19 +0200
smpp34_structs.h: Fix trailing whitespace
Change-Id: I5838e216fe16b4789bb1a0ce40ce496f46a3c328
commit a11a464552736f813656ca17c30c355543cfa573
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-09-15 18:58:47 +0200
smpp34_dumpBuf.c: remove unused variable
Fixes compilation warning below:
smpp34_dumpBuf.c:52:9: warning: variable ‘lefterror’ set but not used [-Wunused-but-set-variable]
int lefterror = 0;
Change-Id: Iea8ff80d3e4d16aaca6e37d64593b50fa27c8cfb
commit 823e711018f053b3878071fe84e929b0623ca08b
Author: Max <msuraev@sysmocom.de>
Date: 2017-08-28 11:51:11 +0200
Use release helper from libosmocore
See
https://osmocom.org/projects/cellular-infrastructure/wiki/Make_a_new_release
for details.
Change-Id: Ief2b4d0400b142e84e7ce005a6da5c880c78a8f5
Related: OS#1861
commit 6d47c170cccd8a72eae985c7ecffba3f07d3861a
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-08-14 19:11:37 +0200
prepare for 1.12 release
Change-Id: If21d2456dd8ebf4bcea0592a841741269b33a308
commit 166c8aacdc9a1640a70b9a5b9227a449d4d02b0a
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-08-14 19:06:36 +0200
update .gitignore
Change-Id: Ie294cb355a6618295e9864358413052837c35a03
commit 1648066f1652e758d93393a875b1337a27fc0cf7
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-08-14 18:55:24 +0200
Use osmocom-style versioning in Makefile, configure, debian/rules
We have a particular method of generating package version information
in the Osmocom project, based on a 'git-version-gen' script that
looks up the latest git tag and generates a version from that.
This version is then used in pkgconfig, etc.
Change-Id: I1e6ed7af7107f8a74010721acd34f92a3237a7a1
commit 6f481f066ed4cd2692abbf994170ac4409d4b809
Author: Pablo Neira Ayuso <pablo@gnumonks.org>
Date: 2017-08-11 14:30:24 +0200
add delivery receipt definitions
The registered_delivery field in SMPP message is a toggle on/off, this
patch adds two new definition so we don't have to use magic numbers from
the code.
Change-Id: I5b3afff1b3b77cccd949e0606914c7ac3ba6114c
commit c283d8431c5c145db1e5a327f9ccea412097c179
Author: Pablo Neira Ayuso <pablo@gnumonks.org>
Date: 2017-08-11 13:09:28 +0200
add esm_class definitions
Add special message attributes definitions that are associated with the
short message. Thus, we can get rid of magic numbers in our codebase.
Change-Id: I91afd8b462b8fd3b2c4c5b54f4eeb7ec5b730b65
commit 9b3cefca217759b52ac1dc5254a0b574229c2be5
Author: Pablo Neira Ayuso <pablo@gnumonks.org>
Date: 2017-08-11 12:11:46 +0200
add smpp34_tlv_for_each() helper
So we don't need to remember this is an opencoded list of TLVs.
Change-Id: I446929feed049d0411e1629ca263e2bc41f714cc
commit cc0bcd6bc051d5ccaf32cdbbc28f073369900857
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-03-17 21:44:28 +0100
README.md: Make sure all hyperlinks use <>
Change-Id: Iebc3f9b60004b4c17f0a35b90c2b226a8f357a10
commit 78b51894fa42f6add9252af14a61ad9068d2192b
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-03-16 20:29:08 +0100
Actually fill the README file with contents (and markdown syntax)
Change-Id: I2343b2fd45d00935c0e27c84e8b55c39765d51f8
commit 63d562c099f11c4d11a952a03bc54659f8b82319
Author: Max <msuraev@sysmocom.de>
Date: 2016-12-21 14:52:20 +0100
Integrate Debian packaging changes
debian/control:
* restructure to make it easier to incorporate further changes
* update package descriptions
* update project URL
debian/rules:
* use proper hardening syntax
* remove useless comment
debian/compat: update compatibility version
debian/*.install: fix paths
debian/copyright: add file matching Debian format
Change-Id: I50b54d7d89f7c7ed3e5a10fbf734d967090f30c7
Related: OS#1694
commit 899400ef72be7ea0cd6fd8504b56b769a10efc84
Author: Max <msuraev@sysmocom.de>
Date: 2016-12-21 14:51:49 +0100
Add gerrit settings
Make it simple to setup and use this repo with 'git review' command.
Change-Id: Ic97dda1950689ed86dcf01a49a0894aedaf57bab
commit 943f079e6635420e9e48d140cecd5c2dcb5a9ea6
Author: Neels Hofmeyr <nhofmeyr@sysmocom.de>
Date: 2016-10-01 00:50:11 +0200
configure: check for pkg-config presence
Change-Id: I6251b2a8e76e5850a346d88fd3c02435b0b445ad
commit 2ccf5304ca465fbc70f6ae3283b4f49aaa9b650f
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2016-07-06 15:30:48 +0200
gitignore: ignore all build artifacts
Change-Id: Ie253062060da2ebf22f1aaf99090c0f144fde52e
commit 8b61a0555ad2d2031dc4012aa8156d6b8d52226b
Author: Ruben Undheim <ruben.undheim@gmail.com>
Date: 2016-05-25 09:03:15 +0200
Fix various typos in log messages
Change-Id: If52a8546b09ac14c00e6323984eda6d88a558830
Reviewed-on: https://gerrit.osmocom.org/115
Reviewed-by: Neels Hofmeyr <nhofmeyr@sysmocom.de>
Tested-by: Jenkins Builder
commit cccf0252554c0f42fa8de4aa3f7bb3534511b94c
Author: Holger Hans Peter Freyther <holger@moiji-mobile.com>
Date: 2016-05-24 23:08:41 +0200
debian: Make upgrading from debian SID easier
Make sure the version number of this sourcepackage is higher than
the one found in Debian SID.
Change-Id: I77126b0b9a8dbc4dcdc02a5a3b4718129b308930
Reviewed-on: https://gerrit.osmocom.org/112
Tested-by: Jenkins Builder
Reviewed-by: Holger Freyther <holger@freyther.de>
commit 0ee4af7405cf6c26796ca8c4194e8ee8bfba843e
Author: Holger Hans Peter Freyther <holger@moiji-mobile.com>
Date: 2016-04-13 18:59:37 -0400
jenkins: Add the build script from jenkins here
This can be used to replicate a build issue more easily.
commit b7c45ce7bec29094180998d0a6aad88607ca3bf6
Author: Holger Hans Peter Freyther <holger@moiji-mobile.com>
Date: 2014-10-01 08:18:43 +0200
test: Be able to bind to a local source/port
Modify the code to show how to configure it.
commit 84f2905c5bfed2e1f5bae52a2bb9bc771fd8b895
Author: Holger Hans Peter Freyther <holger@moiji-mobile.com>
Date: 2014-09-25 20:06:17 +0200
libsmpp: Fix src != build directory build needed for dizzy
commit 7238abebeb9877ce99764f199e8f6b71b0e1f8c8
Author: Holger Hans Peter Freyther <holger@moiji-mobile.com>
Date: 2013-09-24 13:34:12 +0200
debian: Add depedency between packages
commit 724cf227af6cf8832231aaaef1a9be051290adb1
Author: Holger Hans Peter Freyther <holger@moiji-mobile.com>
Date: 2013-09-22 14:51:37 +0200
debian: Add a package
commit 9738dfa897e9558390580a36325180bfb02d6f72
Author: Holger Hans Peter Freyther <holger@moiji-mobile.com>
Date: 2013-09-23 14:33:05 +0200
Rename binary to binaries to fix building a debian package
dh will execute the binary rule and this will not do anything
as a directory with that name already exists..
commit d5944e2225f6e27d0b83cd50a117d1b79aa82a53
Author: Holger Hans Peter Freyther <holger@moiji-mobile.com>
Date: 2013-09-09 11:55:24 +0200
misc: Fix compilation on FreeBSD of the example
Include netinet/in.h and check for FreeBSD for the gethostbyname_r
usage.
commit ef554d088031cc7255bae7b417ac29c01698f43f
Author: Holger Hans Peter Freyther <holger@moiji-mobile.com>
Date: 2013-09-05 22:43:40 +0200
const: Make the data parameter for unpack const
commit a18bad989696b5047fab20e579a6e5a886a4904f
Author: Harald Welte <laforge@gnumonks.org>
Date: 2012-12-18 21:11:16 +0100
build test_apps only if libxml2 is available
commit 226b2b0e6e367c4444adc1d674c88e9e1ef97501
Author: Harald Welte <laforge@gnumonks.org>
Date: 2012-12-18 21:05:37 +0100
binary/Makefile.am: library is in builddir, not srcdir
this will fix out-of-tree builds
commit 88029df59557eb7386a1b16d2578b73f17debdf8
Author: Harald Welte <laforge@gnumonks.org>
Date: 2012-12-18 20:55:26 +0100
add test_apps/Makefile to configure.ac
commit eca1440439df6b7ee6c1166483f0389d71a98102
Author: Holger Hans Peter Freyther <zecke@selfish.org>
Date: 2012-11-09 13:39:51 +0100
misc: Always include stdint.h as it is almost 2013 now
C99 is there for over a decode, always depend on the stdint header
being present, specially as the code is using uint32_t all over the
place.
commit ac4af14ab11b6a61d9c98d2232f5f0a238c5f697
Author: Holger Hans Peter Freyther <zecke@selfish.org>
Date: 2012-11-09 11:49:22 +0100
misc: Use stdlib.h instead of malloc.h to make it compile on FreeBSD
/usr/include/malloc.h:3:2: error: #error "<malloc.h> has been replaced by <stdlib.h>"
commit 9288d59cfdc452fa3a92728149537372ee5c6c56
Author: Harald Welte <laforge@gnumonks.org>
Date: 2012-11-09 09:12:42 +0100
auto-foo: Build test apps with libxml2 only if it is available
And disable the smsc build as it depends on libosmocore
commit a52c99e9e699f5ad264908bf9b19e349c4bcfd9e
Author: Harald Welte <laforge@gnumonks.org>
Date: 2012-11-09 09:00:50 +0100
add missing C files for running a small SMSC-side SMPP implementation
commit bd7039233d90c872b7f7368e91bb008d6f004f38
Author: Harald Welte <laforge@gnumonks.org>
Date: 2012-11-08 15:09:23 +0100
don't install all the test programs to the system!
commit 9787d5998aec759cefc3838b8ecba0dd66623be1
Author: Harald Welte <laforge@gnumonks.org>
Date: 2012-11-08 15:04:38 +0100
add .gitignore
commit ae37eace2fbc0114a9cf220727d7b7bce335c653
Author: Harald Welte <laforge@gnumonks.org>
Date: 2012-11-08 15:01:42 +0100
add pkg-config support
commit e74d4af78053c4adc0be2ed3b52417d1ef9ef860
Author: Harald Welte <laforge@gnumonks.org>
Date: 2012-11-08 15:01:24 +0100
delete auto-generated files
commit 4b233b4f3b22f79c2bdd60703d309c9929f74ab6
Author: Harald Welte <laforge@gnumonks.org>
Date: 2012-11-07 08:32:31 +0100
initial import of libsmpp34-1.10
...