commit 81c6a0a97980f9da76ef0e698ca6ab526b98c7c2
Author: Harald Welte <laforge@gnumonks.org>
Date: 2019-01-20 11:33:23 +0100
Bump version: 0.10.0.39-b723 → 1.0.0
Change-Id: I9b9d9331bdd1d9cdebdef5c3e0c49a1b18972abd
commit 2c880ba6f4a0f6e67ee95fdbabd7ccb5f4797194
Author: Harald Welte <laforge@gnumonks.org>
Date: 2019-01-20 15:10:04 +0100
sccp.c: Fix gcc-8.2 -Werror=maybe-uninitialized
This fixes the following compiler warning when using -Werror on gcc-8.2:
sccp.c: In function ‘sccp_system_incoming_ctx’:
sccp.c:1039:10: error: ‘result.destination_local_reference’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
&& memcmp(&conn->source_local_reference,
result.destination_local_reference,
sizeof(conn->source_local_reference)) == 0
sccp.c:1030:27: note: ‘result.destination_local_reference’ was declared here
struct sccp_parse_result result;
^~~~~~
Change-Id: Ied41f7c8ddaa5f616dd6556079a54d8d70274490
commit 069b20dd6ef4851ce993b523d11775e8bbae15c0
Author: Stefan Sperling <ssperling@sysmocom.de>
Date: 2018-12-19 10:50:18 +0100
fix ipa_asp_fsm down state transition
Properly transition into IPA_ASP_S_DOWN from IPA_ASP_S_ACTIVE
and fix the mask of legal out states from IPA_ASP_S_ACTIVE.
BSC-sccplite tests are still passing with this change.
Change-Id: Idb8e7bd1c74a4b47080fe32ebe0161c503ead571
Related: OS#3111
commit 959290be117dd7dd08bda0e1f4d9d98ada944d49
Author: Oliver Smith <osmith@sysmocom.de>
Date: 2018-12-06 13:43:26 +0100
contrib: fix makedistcheck with disabled systemd
EXTRA_DIST files need to be distributed, no matter if the systemd option
is configured or not.
Change-Id: Ib848aa5ce03f45d4f8182a4e77b0130ccb261635
commit 397903fdb724b22b1c5be1fddb940baa434baa93
Author: Oliver Smith <osmith@sysmocom.de>
Date: 2018-11-30 15:56:41 +0100
contrib/jenkins.sh: build and publish manuals
Add new environment variables WITH_MANUALS and PUBLISH to control if
the manuals should be built and uploaded. Describe all environment vars
on top of the file.
When WITH_MANUALS is set, install osmo-gsm-manuals like any other
dependency and add --enable-manuals to the configure flags (for "make"
and "make distcheck"). Add the bin subdir of the installed files to
PATH, so osmo-gsm-manuals-check-depends can be used by ./configure.
Related: OS#3385
Change-Id: I5904c86c7e38d36d23df213f5a2ae1986647a051
commit c563197778d25a9d0b7b49865dfa3ca31bf3f15e
Author: Oliver Smith <osmith@sysmocom.de>
Date: 2018-12-04 15:39:31 +0100
Fix DISTCHECK_CONFIGURE_FLAGS override
Set AM_DISTCHECK_CONFIGURE_FLAGS in Makefile.am instead of
DISTCHECK_CONFIGURE_FLAGS. This is the recommended way from the
automake manual, as otherwise the flag can't be changed by the user
anymore.
Related: OS#3718
Change-Id: Ib3f443e07f51df352357c5a90792bd946efcdf27
commit b7237b139dde582f1cec084b616ea2e05175b747
Author: Oliver Smith <osmith@sysmocom.de>
Date: 2018-11-14 10:47:01 +0100
build manuals moved here from osmo-gsm-manuals.git
Moved to doc/manuals/, with full commit history, in preceding merge commit.
Now incorporate in the build system.
Build with:
$ autoreconf -fi
$ ./configure --enable-manuals
$ make
Shared files from osmo-gsm-manuals.git are found automatically if
- the repository is checked out in ../osmo-gsm-manuals; or
- if it osmo-gsm-manuals was installed with "make install"; or
- OSMO_GSM_MANUALS_DIR is set.
Related: OS#3385
Change-Id: Ib5a22c2ea81fdde036bf9efb47d785a830b88c93
commit 2162f5d89ed20f20ece30a3f4662b34df95a0753
Merge: 5371a21 e6a0409
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-11-27 18:46:19 +0100
Merge history from osmo-gsm-manuals.git
Change-Id: Iabd0af069f00e7827a7793aabfc38a14fb7f1570
commit e6a0409d6eecdb3ec936418c5db0bd1ad8b4eb96
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-11-05 03:33:44 +0100
stp: update vty reference with added SCCP commands
After I66e97706de0c546db3c6ff77fb5e6ac6e32bff55 which adds the missing
sccp_vty_init(), update VTY reference with the new SCCP show / config commands.
Depends: I66e97706de0c546db3c6ff77fb5e6ac6e32bff55
Change-Id: Id941b8e31d3b4cfdb3f912beedc1e7af321a0113
commit 3508df220073775833a4f89b2716a89b11b71b9e
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-11-05 03:19:56 +0100
stp: update vty reference
Change-Id: Id5f1067760db7a11ec380a541bfe7357a21a3bb3
commit fcc95f960b2c5e3202499f092c8086b4e52fee50
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-03-17 14:15:38 +0100
vty-ref: Update URI of docbook 5.0 schema
... to match the /etc/xml/catalog file on debian (no "www" in hostname)
Change-Id: Id9f3579c7f2bc3af13fe30b5268f249b6f59ed0d
commit 5fab07911dad6a34200f2900e3e9c26e27f07432
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-03-06 14:59:00 +0100
OsmoSTP: update VTY reference
This is the first update since the libosmocore changes to the 'show
online-help' generated output. Hence the produced document now benefits from
the structural improvements:
- not repeating common commands for every node;
- using section names that match the VTY prompt.
Change-Id: I98cdfcb6c1c7db49ab106e775be92e4c6adeab17
commit 51ef55b6d442b1caf5592f2b3a912d819f80606b
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-11-12 08:18:47 +0900
STP: Update vty reference XML file
This ensures useful content in the STP vty reference manual
Change-Id: Ica4b1c0172255ec2328562fdd8fac190e3ad448d
commit 46c4b92926c4fd51aa049cf204d556f520e1e401
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-04-16 03:09:47 +0200
First step towards an OsmoSTP manual
Change-Id: I450bfac7444ac9cb7f50c086d87cf7157c2e2a31
commit 7dd567979a6dda057e19c88adc599a7e4aff8ae5
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-11-27 18:46:00 +0100
Importing history from osmo-gsm-manuals.git
Change-Id: I17bfe64d98ca47cb4b3be81d2715bda047b79466
commit 5371a212937ad5eca33699bad3be8c101ab10cee
Author: Max <msuraev@sysmocom.de>
Date: 2018-11-09 15:54:43 +0100
SS7: safeguard against wrong number of pointcode component
Previously internal function get_pc_comp_shift() returned negative error
code when called with wrong component number despite unsigned return
value which wasn't checked for error anyway.
Fix this by using explicit assert in the error path. This should not
affect external users because this function always called with constant
component argument.
Change-Id: Ib24cdbcf614bad68f3cfa9776a451c5c1e45ae6e
commit c3824bca16e27051b455b4532a04b21e3ee8d2b4
Author: Max <msuraev@sysmocom.de>
Date: 2018-11-09 15:44:40 +0100
Log ip:port for created SS7 server
Change-Id: If2ae093175d64000490a2be31ecfea265ca3853d
commit 8d0343872ecd53e9a9e31984d6588c06e076cb8e
Author: Max <msuraev@sysmocom.de>
Date: 2018-11-09 15:41:35 +0100
Make pointcode width function public
That's useful for external programs veryfying pointcode validity. For
example if used as part of BSS-related identity in GCR construction by
LCLS code we should be able to double.check that no significant bits off
pointcode are lost/ignored.
Change-Id: I5a9981dd2c1d78966c61a3f6b50c7c0d9b542caf
commit b5188f01691d0ff8ae1289479ea26454edeac45f
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-11-05 03:31:41 +0100
osmo-stp: add SCCP related VTY commands
Call osmo_sccp_vty_init(), so far forgotten.
This adds the various 'show cs7 instance N sccp *' commands, as well as making
the SCCP timers configurable.
See Id941b8e31d3b4cfdb3f912beedc1e7af321a0113 for a diff of the VTY reference,
showing what commands are enabled by this patch.
Change-Id: I66e97706de0c546db3c6ff77fb5e6ac6e32bff55
commit 56ac82056a4f7bcdb71984a320fb35cfa4ea6d4a
Author: Stefan Sperling <ssperling@sysmocom.de>
Date: 2018-11-09 14:56:56 +0100
return error code from xua_srv_conn_cb() if conn is freed
Allow callers of xua_srv_conn_cb() to tell whether conn
was freed by returning error code EBADF, which is also
used elsewhere in osmocom programs for this purpose.
This is necessary because xua_srv_conn_cb() might be running
inside of a loop which checks for read and then write events
on the connection. If the connection is freed by xua_srv_conn_cb()
as part of processing a read event, callers should avoid further
processing of events. But if we don't return an error we are leaving
callers none the wiser and with a dangling conn pointer.
Change-Id: I7359667b2f25d6c45acc70049b2a4ee2f376a1df
Related: OS#3685
commit b59ebe9f220fed9655059a72832e51f1b04dcbe1
Author: Stefan Sperling <ssperling@sysmocom.de>
Date: 2018-10-29 19:25:34 +0100
skip simple-client default as/asp when saving VTY config
When saving the current VTY config to a configuration file,
do not write out AS/ASP configuration items which are generated
as a fallback by osmo_sccp_simple_client_on_ss7_id().
Since the user did not explicitly configure these configuration
items they should not be saved to the user's configuration file.
Change-Id: Id8a3afc6dee29ae1ee9c862cbe404a61fe979dba
Related: OS#3616
commit 6a973bab9c5ae4f139ce30aa02e34e3779b8c5fa
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-09-26 20:49:48 +0200
build: move include/{mtp,sccp} to include/osmocom/
Anywhere else in the Osmocom code base, we arrange headers in
include/osmocom/foo/ and pass -I ${root_srcdir}/include/.
This way including an osmocom header always has the format
#include <osmocom/foo/bar.h>
whether we are including from the local source tree or from $prefix.
For some reason not clear to me, the mtp and sccp folders, even though they are
being installed to $prefix/include/osmocom/, were kept *next* to the osmocom/
dir, instead of inside it. Fix that weird situation.
The motivation is that I wanted to use a definition from sccp_types.h in a
public-API header. That is impossible if it requires
#include <sccp/sccp_types.h>
in a local build, but
#include <osmocom/sccp/sccp_types.h>
for any other source tree using libosmo-sccp. After this patch, both are
identical and including works without quirks. (The other patch that needed this
has changed in the meantime on and no longer needs this, but this still makes
sense for future hacking.)
The installed result does not change, since both mtp/*.h and sccp/*.h have
always been installed to $prefix/include/osmocom/{mtp,sccp}/. This merely
changes their position in the source tree.
The most curious situation before this is that any patch #including
<osmocom/sccp/sccp_types.h> might not get a notice that the header didn't
exist, but might instead include an older system-installed file.
Change-Id: I1209a4ecf9f692a8030b5c93cd281fc9dd58d105
commit bb6e4bb6769eb1fc7840e50d0b33126ba7574b29
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-09-26 17:12:23 +0200
make SCCP timers configurable
The previous hardcoded SCCP timers may cause SCCP connection releases, if the
peer is configured with far lower timers than libosmo-sccp. Testing with a
specific SCCPlite MSC, I experienced an iar of just over three minutes, meaning
that calls would be cut off by the MSC, since the osmo-bsc failed to send an
Inactivity Timer message until seven minutes have passed.
With this patch, SCCP timers are configurable by the user.
Define constant global default timers, and variable user-configurable timers
with each osmo_sccp_instance.
Add VTY UI to configure the timers. Users must call osmo_sccp_vty_init() to get
the sccp-timer config nodes under the 'cs7' node. Show the new UI in
ss7_asp_test.vty.
Note that even though this function is not new at all, until recently, all of
our SCCP users (osmo-bsc, osmo-msc, osmo-sgsn, osmo-hnbgw) failed to call
osmo_sccp_vty_init(), and thus also missed out on the various 'show' commands
defined in sccp_vty.c. In other words, to benefit from the timer
configurability, the patches to call osmo_sccp_vty_init() must first be merged
to the corresponding master branches.
If a 'sccp-timer' config command occurs, the cs7 instance must allocate an SCCP
instance in order to store the timer config. Do that by calling the recently
added osmo_ss7_ensure_sccp() function.
Hence remove the limitation that the SCCP instance must not be populated from
the "simple" setup function. If we want to configure SCCP timers beforehand,
there must be an SCCP instance for that, and there is no hard reason to require
a NULL SCCP instance, besides the desire to prevent this function from being
invoked twice.
Change-Id: I28a7362aa838e648ecc9b26ee53dbcade81a9d65
commit eb2068d501cf5731bcfb4db3f8dbaa928a70c202
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-09-27 03:28:19 +0200
sccp_vty: fix doc strings for show ... ssn,connections
For 'show cs7 instance 0 ssn', fix doc string for 'ssn', and add missing one
for the SSN arg. This fixes depending builds that see VTY test failures due to
the missing doc string.
For 'show cs7 instance 0 connectsion', fix doc string for 'connections'.
Change-Id: I214ea51fc6bfa2a9a4dd7c34b43add0c77ffe22e
commit 6d867d1d08490a270be86911b74fcf0a8cede44d
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-09-27 01:21:45 +0200
cosmetic: allocate ss7->sccp in one common function
Instead of allocating ss7->sccp in various places, unify that in one common
function. We shouldn't spread the decision what to pass as priv pointer around
everywhere. There is no functional difference.
This is preparation for a patch where the sccp_instance gets allocated from the
telnet VTY: I would prefer to hide all allocation details from that code; which
also makes sense for the other callers of osmo_sccp_instance_create().
Change-Id: Ie912898c66d31ce4ac8eeeea5a6ddc3f821c06f7
commit 00170f0ebf50bd4d04b54a2ffe3b64d06419590e
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-09-26 22:45:22 +0200
vty: install 'show cs7' for sccp addrs on _ve nodes
The 'show cs7 instance 0 sccp-addressbook' command should not be inside the
'cs7' node. That defies the point of naming the instance again, and it falls
out of place of all the other 'show cs7' commands on the VIEW and ENABLE nodes.
Drop the old command within the 'cs7' node without substitution or deprecation.
At the same time, drop dash from 'show cs7 i 0 sccp-addressbook'
There are various other show cs7 commands already defined in sccp_vty.c, which
have 'sccp' as a separate string. Conform to that.
Change-Id: I80e0bc0a91bcd3fb75372045db34592d2d663d41
commit 2bfe4a07ef418098aad38410c52321f0063bfc4f
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-09-26 22:42:36 +0200
vty: tweak two printed strings
Fix typo "to long".
Say 'cs7 instance' instead of 'ss7 instance': we are interacting with a user on
the telnet VTY, and that user is configuring a 'cs7 instance'. Especially a
lowercase 'ss7' is potentially confusing ("is there an 'ss7' node?").
Changes show in ss7_asp_test.vty.
Change-Id: Iebb976531576268d58338895a4baadbca6137b80
commit 8a9f92bbea44e20baa0004b9b27314a87bbd3f98
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-09-26 23:30:44 +0200
sccp_vty: define SCCP_STR once
Define SCCP_STR in sccp_internal.h, because I know that I want to also use it
in osmo_ss7_vty.c.
Fix "Signaling" to "Signalling" upon copying the old string.
Change-Id: Ic93e4771147070a9222c73f80b5f7c29ae7eec35
commit 4a3e8f5b19c2b9fae62ae7f567657c7e3091fdbb
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-09-26 22:41:40 +0200
add tests/vty: VTY UI transcript testing
Add ss7_asp_vty_test, a shim test program with the sole purpose of exposing the
cs7 VTY nodes.
Add ss7_asp_test.vty, transcript for verifying VTY nodes using above program.
Add --enable-external-tests to configure.
Run jenkins.sh with --enable-external-tests.
Change-Id: I6a28684fa24d6e7de568623444297028eba2ab8c
commit 66f6ed06e17878a2b8c280d58c9f61029d78f86c
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-09-27 00:58:16 +0200
allow less characters for SCCP address book entries
Allowing a whole line of characters as address book name would be a lot,
allowing 512 characters is completely ridiculous. That's more than this entire
commit log message! 32 is plenty.
All linking programs should automatically get the limitation in their VTY
parsing without any changes.
Configs with sccp-addr names > 31 chars will no longer work after this.
Change-Id: I3ecf83d620e46f7bf9857fc60a93d4e240ee3b8a
commit b8cd891148bc7cfd4bf33d48b36ef9b630f5e732
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-09-27 00:17:20 +0200
vty: fix 'show asp' from within 'asp' node
When entering an 'cs7' / 'asp' node, and invoking 'do show cs7 i 0 asp', the
ASP's FSM instance is not yet allocated. Hence attempting to print its status
will result in a segfault.
Spotted this while writing VTY tests that will follow shortly in another patch
(I6a28684fa24d6e7de568623444297028eba2ab8c).
Change-Id: I3ebf498492c6ba69a5dd1c9f36acdabfd6fbdfe1
commit ee5f37e89fca1ec4da294bd024192b85cb9a7c42
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-09-26 23:30:02 +0200
drop inaccurate comment from osmo_ss7_vty.c
Change-Id: I845f6661eaed361b5d4db88140efb8eb79b6b69d
commit 2da2179e82232878ddc95bbeda8f593bea6537b6
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-09-26 16:15:15 +0200
cosmetic: sccp_scoc.c: fix timers definition units
The SCCP timer units are not what the comments say:
Milliseconds are 1000 * seconds, not 100.
Also, microseconds are 1000000 * seconds.
Interestingly enough, MSEC_TO_US() tried to fix the wrong hundredth-seconds to
microseconds by multiplying by 10, however, it should end up at a factor of a
million, not a thousand, hence would result in wrong sub-second fractions.
But, since none of the current timers use sub-second fractions, none of the
timers are actually affected in practice. Hence this patch is merely cosmetic.
Since all use of the timer constants is wrapped in MSEC_TO_US(), we can
transparently fix all those values and their use:
- define the constants in milliseconds (replace "100" with "1000").
- in MSEC_TO_US(), divide-and-mod by 1000.
- in MSEC_TO_US(), actually calculate microseconds.
BTW, I am about to make the timers VTY configurable, but before I get confused,
I'd rather fix these units first.
Change-Id: Ia6c893f734fbdc88873c4ef80f6cacf01ee7763a
commit edfd86b29596e17a4bec30651a765398e0ee409d
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-09-25 20:13:57 +0200
osmo-stp.cfg: Ensure example config is well-formed
Change-Id: I042486249ae1390a4fedbcf356e488451277788f
commit 80cc48abf36a666f4101a2a2c6155326c3da2acd
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-09-14 16:50:14 +0200
debian: Document why enable-static is used in dh_auto_configure
Change-Id: I4a7215d350e023dceadc5826be68ce366a185da1
commit 13d47c043be61324c9b19787bae7d2960f62e982
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-09-12 16:11:40 +0200
Install sample cfg file to /etc/osmocom
Change-Id: I437e6ada9f391eece75b2f2e2af3bec4e8e9f6ce
commit 5a266f64426eac6665bcae87a17b471cd437eebf
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-09-10 12:05:45 +0200
debian/rules: Remove duplicated override_dh_auto_test section
Change-Id: Iaf3a7448d10832cc27afa04fe482da31d7582660
commit 8c481d2825e1135912b5b0f5ae930d8a8cf67385
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-09-10 10:40:22 +0200
Install systemd services with autotools
This commit re-adds ba3da6d72564bb2c60f4f4a8d641b8a7b86d1f59, plus fixes
two typos (sytemd->systemd) in that commit.
The commit is fine, we just need to add some extra configure flags in
osmo-ci.git.
Depends: https://gerrit.osmocom.org/#/c/osmo-ci/+/10857/
Change-Id: Ifc11d97c0c5fe1f7872b59147b1548b56951921b
commit c8143eccc2841781af2f09f31222fcc634114bd5
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-09-09 20:19:27 +0200
Revert "Install systemd services with autotools"
This reverts commit ba3da6d72564bb2c60f4f4a8d641b8a7b86d1f59.
That commit broke master-{osmo-iuh,osmo-msc,osmo-sgsn,openbsc,osmo-bsc}
build jobs with
make[4]: Nothing to be done for 'install-exec-am'.
/bin/mkdir -p '/lib/systemd/system'
/usr/bin/install -c -m 644 osmo-stp.service '/lib/systemd/system'
/usr/bin/install: cannot create regular file '/lib/systemd/system/osmo-stp.service': Permission denied
make[4]: *** [install-systemdsystemunitDATA] Error 1
Change-Id: I009825d293e7e7a6c48d10452c10b3bb6da3e684
commit ba3da6d72564bb2c60f4f4a8d641b8a7b86d1f59
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-09-07 17:45:52 +0200
Install systemd services with autotools
Change-Id: Ie77ee4b32a75e2d207030ddc78d39fb664103d33
commit a0dd986f5506ee8a625e827bc029d1aa962b6f65
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-07-10 17:22:03 +0200
ipa_asp_fsm: init: expect IPA ID ACK, not GET
Testing with an actual SCCPlite MSC, I see the IPA connection starting out by
the MSC sending an IPA ID ACK. Make the ipa_asp_fsm match that.
Change-Id: Icffda98579e676ab6ca63c9c22cf5d151c4fe95f
commit 39fdaf62ba724c1e343ab281911ba844b6b88989
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-08-13 17:51:35 +0200
xua_rkm: Fix xua_msg memleank in handle_rkey_reg_resp
From LeakSanitizer report:
Indirect leak of 384 byte(s) in 3 object(s) allocated from:
#0 0x7f986da27d99 in __interceptor_malloc /build/gcc/src/gcc/libsanitizer/asan/asan_malloc_linux.cc:86
#1 0x7f9868d0cb61 in _talloc_zero (/usr/lib/libtalloc.so.2+0x5b61)
#2 0x7f986ad33766 in xua_msg_add_data /home/pespin/dev/sysmocom/git/libosmo-sccp/src/xua_msg.c:73
#3 0x7f986ad343c3 in xua_from_msg_common /home/pespin/dev/sysmocom/git/libosmo-sccp/src/xua_msg.c:143
#4 0x7f986ad347d2 in xua_from_nested /home/pespin/dev/sysmocom/git/libosmo-sccp/src/xua_msg.c:201
#5 0x7f986ad65563 in m3ua_rx_rkm_reg_rsp /home/pespin/dev/sysmocom/git/libosmo-sccp/src/xua_rkm.c:431
#6 0x7f986ad65f96 in m3ua_rx_rkm /home/pespin/dev/sysmocom/git/libosmo-sccp/src/xua_rkm.c:510
#7 0x7f986ad31ef7 in m3ua_rx_msg /home/pespin/dev/sysmocom/git/libosmo-sccp/src/m3ua.c:749
#8 0x7f986ad7c1e8 in xua_cli_read_cb /home/pespin/dev/sysmocom/git/libosmo-sccp/src/osmo_ss7.c:1590
#9 0x7f986a66cdb4 in osmo_stream_cli_read /home/pespin/dev/sysmocom/git/libosmo-netif/src/stream.c:192
#10 0x7f986a66e091 in osmo_stream_cli_fd_cb /home/pespin/dev/sysmocom/git/libosmo-netif/src/stream.c:276
#11 0x7f986994e795 in osmo_fd_disp_fds /home/pespin/dev/sysmocom/git/libosmocore/src/select.c:217
#12 0x7f986994eabb in osmo_select_main /home/pespin/dev/sysmocom/git/libosmocore/src/select.c:257
#13 0x5630cb294bd3 in main /home/pespin/dev/sysmocom/git/osmo-msc/src/osmo-msc/msc_main.c:697
#14 0x7f98678b806a in __libc_start_main (/usr/lib/libc.so.6+0x2306a)
#15 0x5630cb292649 in _start (/home/pespin/dev/sysmocom/build/new/out/bin/osmo-msc+0x185649)
Following code paths:
m3ua_rx_rkm_reg_rsp
xua_from_nested
xua_from_msg_common
xua_msg_add_data
talloc_zero (part)
handle_rkey_reg_resp
Take the chance to fix the same issue in m3ua_rx_rkm_dereg_rsp.
Change-Id: I0b15d81099a9f8274b7e39962caa339da644e0dc
commit 9c3baa89fb6b3fc1ef588930f361d013f98a1e39
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-08-13 17:24:41 +0200
sscp_scrc: Fix memleak of xua_msg when handing it to scrc_rx_mtp_xfer_ind_xua
Fixes following error provided by LeakSanitizer:
Indirect leak of 1496 byte(s) in 11 object(s) allocated from:
#0 0x7f1eb3332d99 in __interceptor_malloc /build/gcc/src/gcc/libsanitizer/asan/asan_malloc_linux.cc:86
#1 0x7f1eae617b61 in _talloc_zero (/usr/lib/libtalloc.so.2+0x5b61)
#2 0x7f1eb063e365 in xua_msg_alloc /home/pespin/dev/sysmocom/git/libosmo-sccp/src/xua_msg.c:49
#3 0x7f1eb0650ee3 in osmo_sccp_to_xua /home/pespin/dev/sysmocom/git/libosmo-sccp/src/sccp2sua.c:1298
#4 0x7f1eb0668d6a in mtp_user_prim_cb /home/pespin/dev/sysmocom/git/libosmo-sccp/src/sccp_user.c:173
#5 0x7f1eb068ba86 in deliver_to_mtp_user /home/pespin/dev/sysmocom/git/libosmo-sccp/src/osmo_ss7_hmrt.c:94
#6 0x7f1eb068bf00 in hmdt_message_for_distribution /home/pespin/dev/sysmocom/git/libosmo-sccp/src/osmo_ss7_hmrt.c:133
#7 0x7f1eb068d345 in m3ua_hmdc_rx_from_l2 /home/pespin/dev/sysmocom/git/libosmo-sccp/src/osmo_ss7_hmrt.c:275
#8 0x7f1eb063c08f in m3ua_rx_xfer /home/pespin/dev/sysmocom/git/libosmo-sccp/src/m3ua.c:586
#9 0x7f1eb063cea6 in m3ua_rx_msg /home/pespin/dev/sysmocom/git/libosmo-sccp/src/m3ua.c:739
#10 0x7f1eb0687188 in xua_cli_read_cb /home/pespin/dev/sysmocom/git/libosmo-sccp/src/osmo_ss7.c:1590
#11 0x7f1eaff77db4 in osmo_stream_cli_read /home/pespin/dev/sysmocom/git/libosmo-netif/src/stream.c:192
#12 0x7f1eaff79091 in osmo_stream_cli_fd_cb /home/pespin/dev/sysmocom/git/libosmo-netif/src/stream.c:276
#13 0x7f1eaf259795 in osmo_fd_disp_fds /home/pespin/dev/sysmocom/git/libosmocore/src/select.c:217
#14 0x7f1eaf259abb in osmo_select_main /home/pespin/dev/sysmocom/git/libosmocore/src/select.c:257
#15 0x55666c1bebd3 in main /home/pespin/dev/sysmocom/git/osmo-msc/src/osmo-msc/msc_main.c:697
#16 0x7f1ead1c306a in __libc_start_main (/usr/lib/libc.so.6+0x2306a)
#17 0x55666c1bc649 in _start (/home/pespin/dev/sysmocom/build/new/out/bin/osmo-msc+0x185649)
The code path is the following, starting from mpt_user_prim_cb:
mtp_user_prim_cb
osmo_sccp_to_xua
xua_msg_alloc
scrc_rx_mtp_xfer_ind_xua
sccp_scoc_rx_from_scrc
scrc_node_6
scrc_node_4
scrc_translate_node_9
So the xua_msg is created in mtp_user_prim_cb through osmo_sccp_to_xua
and then handed over to scrc_rx_mtp_xfer_ind_xua which transfers the
xua_msg and thus should take ownserhip of it, and consecuently freeing
it once it's done using it.
Change-Id: I43e159c82b64bd85b185f77ee19b6455a96e082f
commit c3b1f636c94c01bf190713e2d17e2ffd1a58be9a
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-08-06 11:12:33 +0200
debian/rules: Don't overwrite .tarball-version
The .tarball-version file should contain the *source version* uniquely
identifying the git commit, and not the Debian package name.
With https://gerrit.osmocom.org/#/c/osmo-ci/+/10343/ there is a correct
.tarball-version file in the .tar.xz of the nightly source packages.
Change-Id: I620c96eb311be6fdd4187bdcc311ea893ad93614
Related: OS#3449
commit 1a0d15305d4c973949d3f9491bd42d170d670900
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-08-01 13:34:08 +0200
Migrate from ipa_ccm_idtag_parse() to ipa_ccm_id_resp_parse()
In libosmocore Change-ID I1834d90fbcdbfcb05f5b8cfe39bfe9543737ef8f
we have introduced ipa_ccm_id_resp_parse() as a bugfixed replacement
of ipa_ccm_idtag_parse().
The main difference is that the returned "value" parts now have
a correct reported "length", whereas before this commit they all
reported a one-byte too-long "length" for each IE.
Change-Id: I3c79d3bb56cc1370b9922e64d13d2d5508fd8039
commit 688f2304056029f47073a549d7e41043eab5a0fd
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-07-27 18:45:40 +0200
Bump version: 0.9.0.20-6265-dirty → 0.10.0
Change-Id: Ia087b9f03a73a08f0eaa461f61c6244aaf13e3d4
commit 6265190fc611e468cebadb4eaf41ceb2f7e2095b
Author: Daniel Willmann <dwillmann@sysmocom.de>
Date: 2018-07-24 17:51:58 +0200
git-version-gen: Don't check for .git directory
This check is not in all our repos that use git-version-gen. Indeed it
seems to be a leftover of openbsc where I think it wanted to ensure
being called in the openbsc subfolder or something? libosmocore e.g.
doesn't have it.
In any case .git being a directory is not always true (if using git
worktree) so remove this check.
Change-Id: Ic14561f3b041bb94d1b60e477b18e37077ce4c32
commit b3d32cd25efc05f1b6a2266767070b14e6d8966f
Author: Stefan Sperling <ssperling@sysmocom.de>
Date: 2018-07-20 13:40:05 +0200
remove unused -p option from getopt() call in sccp_demo_user
Change-Id: I31f30d8c855cb5faf3173987bfe5b36f5a585d02
Depends: I7432e6fc2617e0fd77a098fcd7d14abc40db7229
commit 118fc8a708c8053a808b3204d6254240ed2d4081
Author: Stefan Sperling <ssperling@sysmocom.de>
Date: 2018-06-16 11:30:47 +0200
sccp_demo_user: use point code 23 for server and 1 for client
Fix previous commit 4dc9088cabedc40cb9072814237ad5926b12bd35 which
broke this by using -1 for local and 23 for remote PC, for both
server and client.
Change-Id: I7432e6fc2617e0fd77a098fcd7d14abc40db7229
Related: OS#2666
commit 5a188137dc0dced617c2a4a0bf2e9484e7187be2
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-07-11 05:23:05 +0200
comment: explain xua_msg free in m3ua_rx_xfer()
Change-Id: I6211c8809eefeb94289c4c497553561b043ee619
commit bf4392c2baff6eac938edf71450f85ef48c311f6
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-07-11 05:01:26 +0200
fix two memleaks in ipa_rx_msg_sccp()
1: Do not call xua_msg_alloc() which is later bluntly overwritten by
m3ua_xfer_from_data().
2: After dispatching to m3ua_hmdc_rx_from_l2(), call xua_msg_free().
Related: OS#3393
Change-Id: I0918f9bbc15b036619f1c25a133b69819b2a30fa
commit 28c8a4bf2fbee013a2c82e19063940ec4cc80414
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-07-11 02:58:00 +0200
add osmo_xua_msg_tall_ctx_init()
So far the tall_xua ctx used to allocate from in xua_msg_alloc() was never
initialized, actually hiding memory leaks from the talloc report.
Add this API to allow branching the xua_msg ctx off a sane root ctx.
Explicitly initialize tall_xua to NULL, so that, if xua_msg_ctx_init() isn't
called, tall_xua is still guaranteed to not be a random pointer.
osmo-bsc will use this function to hook the tall_xua ctx to osmo-bsc's own root
ctx.
Change-Id: I618878680a096a7f7fc2d83098590f2e4cb08870
commit 6f103ae2b57f769d1e2f4193f26de5c414ae0d94
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-07-11 02:30:38 +0200
cosmetic: sccp2sua.c: log the IEI for parsed SCCP addr
Before this, the log looked like it parsed the same address twice with
differing results:
DLSUA DEBUG sccp2sua.c:333 Parsed Addr: RI=2,PC=1196,SSN=254
DLSUA DEBUG sccp2sua.c:333 Parsed Addr: RI=2,PC=100,SSN=254
Adding the IEI clarifies this:
DLSUA DEBUG sccp2sua.c:333 IEI 259: Parsed Addr: RI=2,PC=1196,SSN=254
DLSUA DEBUG sccp2sua.c:333 IEI 258: Parsed Addr: RI=2,PC=100,SSN=254
(I'd have liked to print the IEI name from sua_iei_names, but I frankly can't
figure out how to reach that value_string array "hidden" behind a xua_msg_class
struct, and neither can I find any other code doing so.)
Change-Id: I64adb31129684b2eb66fff581040017ce2f6d163
commit 37169067b7b5a03d824cf9e2c59418953eeca5d4
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-07-11 02:29:34 +0200
fix memleak in ipa_rx_msg_sccp
After m3ua_xfer_from_data() has copied the msgb data, we need to free the msgb.
Change-Id: I2263751c0aa3ae32455847c7622af8be0a1e7802
commit 15ffba535ba0e6b81411ad5726630c5934dece50
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-07-02 16:48:13 +0200
debian: Package installed example doc files
Change-Id: I1d955ccf83c825d7a648a7e140bb20e10f5ddff3
commit b241a2644922d87f5498bb301c06ec7d327ea0c3
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-07-02 16:44:39 +0200
build: Install example cfg files
Change-Id: I93b73032b9a01a1e121ecf7c0cfcf3d5558efc7f
commit 97db03a68246b7821de144b0ef41ad6ad7486610
Author: Stefan Sperling <ssperling@sysmocom.de>
Date: 2018-06-14 11:03:52 +0200
rename m3ua_example to sccp_demo_user
The new name allows for more natural naming of variables in TTCN3
code when this program is used as a TTCN3 test component.
Consider e.g. "SCCP_DEMO_USER_VTY" vs. "M3UA_EXAMPLE_VTY".
Change-Id: I92b5e16e765a1ac36371a16933389903628f8dfe
Related: OS#2666
commit 4dc9088cabedc40cb9072814237ad5926b12bd35
Author: Stefan Sperling <ssperling@sysmocom.de>
Date: 2018-06-12 18:55:50 +0200
make it possible to pass parameters to m3ua_example
There are plans to use the m3ua_example tool as an SCCP peer
for a TTCN3 test suite. Make it possible to pass paramters to
this tool so the user can override hard-coded default values
of IP addresses, ports, and point codes.
Change-Id: I52243ae926c76020de41c8dfc7263517c7263d7e
commit 5d571ce044dc95763a5a557b11f0ac90ff925e99
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-05-26 11:32:50 +0200
Introduce osmo_ss7_register_rx_unknown_cb() for unknown PPID/StreamID
Applications may be interested in handling data for those SCTP PPID or
IPA StreamID which libosmo-sigtran doesn't implement
natively/internally.
Let's add osmo_ss7_register_rx_unknown_cb() using which applications
can register a call-back to implement whatever behaviour they'd want for
those PPID/StreamIDs.
Change-Id: I8616f914192000df0ec6547ff4ada80e0f9042a2
commit 7eb45887b32d9b16c1ea45ab995a6d0398887056
Author: Stefan Sperling <ssperling@sysmocom.de>
Date: 2018-06-06 17:23:53 +0200
fix use after free in osmo_sccp_simple_server_add_clnt()
The variable as_name was freed before being passed to the
osmo_ss7_route_create() function. Free it later to avoid
a use-after-free crash with address sanitizer.
Found by running 'examples/m3ua_example aaa' with address
sanitizer enabled.
Change-Id: I9d724bc1d2aa8d6f8b6a67bdeafdb5f0f9136413
Related: OS#2666
commit ee770e5b5d9b91266177b0689f671e13d4eb087d
Author: Stefan Sperling <ssperling@sysmocom.de>
Date: 2018-06-05 19:10:43 +0200
fix infinite recursion with routing by global title
We don't implement routing by global title address.
When processing an SCCP message which is routed by global title,
don't recurs indefinitely until the stack is exhausted.
Instead, return an error with cause SUBSYSTEM_FAILURE, which we
also do in other routing failure cases.
Change-Id: I24621e77ffc979bc337775f9c6a4ad9a9068625a
Related: OS#2666
commit 3baa5da96d48b889a448ccbb1d3c841960a40bb8
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-05-26 11:35:08 +0200
osmo_ss7: Register 5000 as default port for IPA/SCCPlite
Makes sure that in absence of a user-specified port number,
osmo_ss7_asp_protocol_port() will return 5000 as default port number.
Change-Id: I628ee095603742a652fd971887e02cc17d1f71b8
commit 1ba800e36c48e959948b4413832dda185c7a5ea8
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-05-16 14:36:17 +0200
tests: xua_test: Fix array len computation
As warned by gcc 8.1.0:
In file included from libosmo-sccp/include/osmocom/sigtran/osmo_ss7.h:7,
from libosmo-sccp/include/../src/xua_internal.h:3,
from libosmo-sccp/tests/xua/xua_test.c:21:
/include/osmocom/core/utils.h:13:34: error: division ‘sizeof (const uint8_t (*)[12] {aka const unsigned char (*)[12]}) / sizeof (const uint8_t[12] {aka const unsigned char[12]})’ does not compute the number of array elements [-Werror=sizeof-pointer-div]
#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
^
libosmo-sccp/tests/xua/xua_test.c:371:45: note: in expansion of macro ‘ARRAY_SIZE’
#define PARTARR(x, data) { .tag = x, .len = ARRAY_SIZE(data), .dat = (uint8_t *) data }
Change-Id: Iad5703d68fee26fc83958741512820d2539e604e
commit 920b22c4733dade054415a99de14e56eaaea1e7f
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-05-16 14:32:19 +0200
tests: xua_test: Fix use of wrong buffer for dest addr
All the others parts use that buffer as its name indicates.
Change-Id: Ide7fe148cc762153330b08f66737816ceed96cb2
commit 3b8ff68a0a3c6d495690a68c1663abfbed25870f
Author: Stefan Sperling <ssperling@sysmocom.de>
Date: 2018-05-08 15:52:30 +0200
free msgb for primitive allocated in lm_timer_cb() of lm_fsm
A primitive allocated in lm_timer_cb() with xua_xlm_prim_alloc()
was never freed. Don't forget to free the msgb in osmo_xlm_sap_down().
Found by code inspection.
Also, assert that allocation suceeded like we do elsewhere.
Change-Id: Ie667b1b8beeda2aa4520a1413f51101435215cc0
Related: OS#2449
commit b7d9255f1b064ecd4a2951619b97a00e915d2967
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-04-28 13:46:06 +0200
debian/control: match build dependency versions with configure.ac
So far, 'debian/control' didn't express the minimum version numbers
of the libosmocore + libosmo-netif build dependencies. This resulted
in build failures against older libosmocore/libosmo-netif versions,
so let's make sure the minimum veresion requirements are expressed
also in debian/control.
Change-Id: I1c874880d8b2569df7acc1af554f7a4dd30e649e
commit c88605c41c25b34d2e2b08f0e1028c2bd6d9404b
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-05-03 17:08:07 +0200
Bump version: 0.8.1.43-7e34-dirty → 0.9.0
Change-Id: Ie3d11408f35509138475e7edde285e1bf5bef8e0
commit 7e3476dc769d42d851a7d77abecfe193cfdefbc7
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-04-17 14:21:55 +0200
use osmo_init_logging2
Change-Id: I0d45b9381125c496a691ac5da68190b7b3479fc3
commit f1fa4a7a9c0debd481234d2a188b1a06e440d65b
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-04-16 22:55:15 +0200
ipa_asp_fsm: Prevent against integer underflow
Ensure we don't pass a negative integer as "unsigned int len" to
ipa_asp_fsm_wait_id_get(). This could result in a remotely-triggered
integer underflow.
Change-Id: Idf9a5c0938e6ae6d47bf85ddfec3306fa3ddb3ce
commit 58fcc5344ea0e914c7f9be69c309998d243142bd
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-03-05 20:51:22 +0100
jenkins.sh: use --enable-werror configure flag, not CFLAGS
Change-Id: I5c3f11586d48a076479eb19ed80a11caad4251d8
commit 2d5026b92b98f72b03254e42823983ba0da1e319
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-03-05 20:39:36 +0100
configure: add --enable-werror
Provide a sane means of adding the -Werror compiler flag.
Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"',
but that actually *overwrites* all the other CFLAGS we might want to have set.
Maintain these exceptions from -Werror:
a) deprecation (allow upstream to mark deprecation without breaking builds);
b) "#warning" pragmas (allow to remind ourselves of errors without breaking
builds)
As a last configure step before generating the output files, print the complete
CFLAGS and CPPFLAGS by means of AC_MSG_RESULT.
Change-Id: Idb579d546d6f228e86bd49ca15aa87b86978205a
commit 3137be99ef2e75bd5bdd616a6c435513a64125ec
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-02-20 20:20:10 +0100
contrib: jenkins.sh: Disable doxygen in libosmocore build
Change-Id: I7abc8862a63d448408ae43802da689fe436a0ff0
commit 7f0b9084805d7d934cf0820d396e12236ddd3cae
Author: Max <msuraev@sysmocom.de>
Date: 2018-02-13 14:43:00 +0100
SS7: clarify handling of stream opening error
Add comment clarifying why we've just logged error but continued anyway.
Change-Id: I2ce55983b255b0b50fd5142d6ddf188dc8ee20b9
commit 60d4be5427444f8e7ce1bb4f089981fed457dfc1
Author: Martin Hauke <mardnh@gmx.de>
Date: 2018-02-10 18:08:21 +0100
build: AC_PROG_LIBTOOL is the same as LT_INIT
Change-Id: I30f8d289d9dca892e40cd7ed787029fbcafa2dff
commit d4c9dc4b9188af3cd31fa6c12f11ad7e3d4edc79
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-02-09 12:11:05 +0100
debian/control: Fix Vcs-Browser
Change-Id: I9bc4ee167a141b91f573d038ad524a9cf097ab34
commit b956b606d85a72dd19cb3ad632c2b4a965da37ef
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-01-17 19:17:34 +0100
sccp_types.h: Fix value for SCCP_REFUSAL_UNEQUIPPED_USER
It seems we have been sending the wrong numeric value in SCCP connection
refusal due to an unqeuipped user. It turns out our list of refusal
causes was missing one entry, causing an off-by-one for this refusal
cause. While at it, add a comment which section of which spec is
relevant for this enum.
Change-Id: I113645bd6df1ec9ae5137977028df38560fc4789
commit 8254cf4f2a66fab40a31c1bdccfff13947ff6592
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2017-12-25 00:45:24 +0100
error log: sccp_scoc.c: log failure to create/resolve conn_id
Tweak the FIXMEs to clarify that we're lacking a reply to the SCCP user besides
log output.
Change-Id: Ib235ff8e264aaf0c2e9794f464a3ba7b54816f3d
commit 16676cf05ac666229f766e01aa69264e1457624d
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2017-12-24 20:29:21 +0100
cosmetic: hmrt_message_for_routing(): use osmo_ss7_route_name()
Change-Id: Iae524c38cd91383a59c64bf7919d94ba7ff350bd
commit 8800b7cf9f8cce510cd78d4b7c100d2a5dc85a12
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2017-12-24 19:27:55 +0100
add osmo_ss7_route_name()
There is a naming dilemma: though the osmo_ prefix is now reserved for
libosmocore, all surrounding API already has the osmo_ prefix.
This will be used by osmo-hnbgw's VTY 'show cnlink' command.
Change-Id: Ia0d15a2814b08bc3f052a1ed12dbb68bade55309
commit e4a77d46735046c09c3b58e9c404539bb5b8e2af
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2017-12-24 16:12:42 +0100
add osmo_sccp_user_name()
There is a naming dilemma: though the osmo_ prefix is now reserved for
libosmocore, all surrounding API already has the osmo_ prefix.
This will be used by osmo-hnbgw's VTY 'show cnlink' command.
Change-Id: Ib7abf69cfcf4c56273223054b280458451e6c2f6
commit d23e38020fdbb685570145acd3a35e22a5a91344
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2017-12-24 16:34:22 +0100
typo: osmo-stp main: 'Erro'
Change-Id: Ibb28f48b46a4b86c62770b4d22dcf735717aeadb
commit ed287f2b878cadd49d2673cb650f0d603ddb0d9c
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2017-12-24 16:22:39 +0100
osmo_sccp_addr_name / _dump: drop 'NO_GT' output
Do not print the GTI if gti is set to OSMO_SCCP_GTI_NO_GT and no GT is present
in the address.
If addr->gt.gti is set to OSMO_SCCP_GTI_NO_GT, i.e. currently always,
osmo_sccp_addr_name() and osmo_sccp_addr_dump() output
",GTI=NO_GT" in every address dump, which is useless clutter. Drop that.
However, if a Global Title is flagged in addr->presence, still output the GTI
to highlight situations where GTI might mismatch the presence of a GT.
Change-Id: I9f87b2b703223ecb5d0442b6199c5b779fe544a1
commit 1aa2a42eae63eaf591306e5a5021fc5453de6da9
Author: Max <msuraev@sysmocom.de>
Date: 2017-12-21 17:05:35 +0100
Enable sanitize for CI tests
Change-Id: Ida8cfcd9a9f86e65273452afa051381bc0c16421
commit 10d4815bb1b4b548ec0bc97611b2e7ac45e0ebc5
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-11-17 12:57:25 +0100
ss7: Re-bind xUA server socket after setting new IP
In osmo-stp, cmd "local-ip" inside node "listen m3ua 2905" was actually
not being applied, because the server was created + bound at "listen" command
time using NULL as IP, and at "local-ip" time the IP was changed but the
server was not re-bound using the new IP, so it kept listening at
0.0.0.0.
With this patch, we defer binding the socket to "local-ip" cmd time,
after the IP has been applied.
As a result, if no "local-ip" command is provided, then the bind never
happens, which means it is now mandatory that users of osmo_ss7_xua_server_create
API not using osmo_ss7_xua_server_set_local_host call new provided API
osmo_ss7_xua_server_bind. Another new API osmo_ss7_bind_all_instances is
provided to easily make sure all servers are bound after configuration
process. This is specially important for servers which doesn't contain
the "local-ip" parameter.
Users of osmo_sccp_simple_server API are not affected by this change,
and they not requrie to call any new API.
Furthermore, using osmo_ss7_xua_server_bind in VTY code ensures the xUA
server is automatically bound to the new address if the operator changes
the "local-ip" cmd at runtime.
Related: OS#2647
Change-Id: I79738963d633bec70705ff159c5b2127cd498aa2
commit 6cd8d1243711f4de2f1314c7b87b972572cdec4e
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-12-10 22:35:08 +0100
Allocate SCCP user primitives with headroom
In I19cb83302aaa404ab1a2d92e6f2aec43d0380426 I set the headroom of
msgb's for SCCP User primitives to zero, assuming that we wouldn't
need any headroom in those primitives.
According to pespin, osmo-msc however needs this headroom:
DLSCCP <002e> sccp_user.c:156 Delivering N-CONNECT.indication to SCCP User 'OsmoMSC-A'
msgb(0xadfba0): Not enough headroom msgb_push (0 < 264)
So let's make sure the new SCCP User primitives are allocated with the
same headroom, just like before I19cb83302aaa404ab1a2d92e6f2aec43d0380426.
Change-Id: I92d7648f8ffd034341e2f12aa79dd3d16ec3a98d
commit 9af7028ebe72bb5bf47713f11b4e111ed83c0693
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-12-10 14:13:33 +0100
sccp_helpers: don't return msgb with l2h set
It's a bad idea to use sccp_msgb_alloc() for SCCP User Primitive msgbs.
The rationale is quite simple: The SCU msgb's are used for wrapping
osmo_prim. The user payload data (e.g. BSSAP) in such primitives is
found at msgb->l2h. However, user payload data is optional. So in a
SCU primitive without user data, we must have msgb->l2h == NULL.
The old behavior resulted in bogus data (actually the sccp_user_prim)
to be contained in the DATA section of SCCP messages such as RLSD/RLC.
Also, the old implementation of scu_msgb_alloc() discarded the 'name'
argument and replaced it with a static "SCU" which was of course another
bug.
Change-Id: I19cb83302aaa404ab1a2d92e6f2aec43d0380426
Related: OS#2732
commit 081ac9c0292298f7992916d8f1b64faf764d4174
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-11-20 21:00:37 +0100
xua_as[p]_fsm: Use osmo_timer_del() on FSM cleanup
When we destroy a FSM, we (logically) must osmo_timer_del() any running
timers that the FSM might have been using. This was not implemented
for xua_as_fsm, xua_asp_fsm and also missing from ipa_asp_fsm.
Change-Id: I670df831d7bc30de48ed4277648a461e1e1968fa
Related: OS#2668
commit 646f47d5a33b945397acea833b326c1e244e827a
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-11-20 19:27:49 +0100
Add "show cs7 (m3ua}sua}ipa)" command to show xUA servers
Change-Id: If072e009f4a95a66e0da1576958ab4d3e227d87e
commit 116dfb662158b45ff374cc91ee6bbb74aacf8b7e
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-11-17 14:45:52 +0100
contrib/test: Fix config of local/remote ports
The first port is the remote one, and the second port is the local one,
according to cs7_asp_cmd doc and code. In the same config, the ports for
the servers are used and for the local port in the client we don't care,
that's why we use 0 there.
Change-Id: I0fafd07614068a27c19bc2dfa6491b4b0c6737fb
commit 73a7435d28780b129a391002a366681c15aed2ef
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2017-11-17 03:33:59 +0100
xua_test: sanitize: fix msgb leak
Change-Id: Ie57e803bb6361f39042084a21cada754a6506606
commit a17ecfa7b174f0104ff124666706662dd88394b5
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2017-11-17 02:55:35 +0100
sccp_test: sanitize: don't memcmp NULL pointers
Change-Id: I0159a875c1e11f4f9728d9e09f5c365b8174673a
commit 3867a7422a5e52a31b3268c9034984c64b2f997b
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2017-11-17 02:55:08 +0100
sccp_test: sanitize: fix msgb mem leaks
Change-Id: I6d5ff3e4c053db5a2af9d548250f0307e00317bb
commit 0a30a8522d3f4d4a1593269daef1498c3411b9df
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2017-11-17 01:43:36 +0100
add --enable-sanitize config option
Change-Id: Ie9bf734cb6cdee24e776cd64f9f1b800a7a9277c
commit 7d9a19739068edc0267fc5a91a81bc3cd0890783
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-11-17 14:37:14 +0100
ss7_vty: Fix out-of-bounds access in 'as' cmd
Change-Id: I180d2ecbb266d9baf2a96017bab20760bb42812e
commit b393b3f4cc8a83e1e58c44187a383050378d860f
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-11-13 01:25:47 +0900
Add SPDX-License-Identifier + missing copyright statements
Change-Id: I113232bbeaa7a835871df7f9b883ba573d8a2534
commit 658cb0ff2e035ba77a15a257560c8165ba903bd4
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-11-13 01:25:16 +0900
debian/copyright: Fix upstream-name
Change-Id: I0ee80d9d6ffe7936849c23942498fe9b7058a88a
commit ed1daa2c8f27af60d61380ed075f16c5f77e3027
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-11-12 08:19:53 +0900
STP: Add osmoappdesc.py
Change-Id: I60362d78b5db3ed5bc96c84a8523c391ff7f8125
commit 3c1e65023a5e5247aec89ef8374aa374e542f534
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-11-12 08:21:09 +0900
osmo-stp: Align prompt formatting with other Osmocom programs
In all other Programs we have the VTY like OsmoBSC, OsmoMSC, etc.
so let's make sure osmo-stp also uses OsmoSTP and not osmo-stp.
Change-Id: Ic91010779ad22c41e28ed4cf43c2e3ab679214b5
commit 510375efd3893bf927d9b50823e080d79020e8de
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-11-11 23:46:29 +0900
ipa: Automatically create / destroy route on IPA connect/disconnect
From the STP point of view: In order to be able to route messages back
to an IPA client, we need to create a route at the time we have
successfully identified the AS for this client based on the name
presented in the IPA CCM ACK "name" field. Once the IPA client is
destroyed, the route must be deleted again.
With this commit present, we can have an IPA client (such as
osmo-bsc-sccplite) connect to OsmoSTP and exchange BSS[M]AP
with an M3UA-speaking osmo-msc. Basically, the STP reaches
the point where it can translate between IPA-style SCCPlite
and proper M3UA/SUA on the other side.
Change-Id: I901f06c5d0f2eae60f8d931215ed65190330ce66
commit bc44437a4370843886dc993223885cafbcd50ea4
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-11-10 16:42:43 +0900
ipa: Patch DPC/OPC information into SCCP Calling/Called Party Address
When we receive a SCCPlite message from an IPA peer, it may simply
contain a SSN number but no point codes. Similarly to creating a fake
MTP routing label from override DPC and routing key OPC, we can also
add that point code information to the SCCP header. This way the rest
of the SS7 network can handle the message and route it accordingly.
Change-Id: I4a2ff063e3c060641b3fd181a1cd600da3ec568b
...