commit c775ffe1cc6cfd842566d30c96d287502d9d6218
Author: Harald Welte <laforge@gnumonks.org>
Date: 2019-01-19 22:28:02 +0100
Bump version: 0.3.0.6-a555 → 0.4.0
Change-Id: I99a3244f922382468251df675287520ca40d9d0d
commit dc8fcf5a696781048e2287e058f2b21af6164c9e
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-12-10 13:11:41 +0100
logging: fix typo in stream.c
Change-Id: I5dcae1f19e18f04709ce7585943af1d582ebc7ed
commit a555a1fca28f6ba1c5c877bb3d94f2b77396ed64
Author: Stefan Sperling <ssperling@sysmocom.de>
Date: 2018-11-09 15:04:12 +0100
detect freed connections in osmo_stream_srv_read()
While we are processing a read event, the connection's
callback might free the connection. Check for this and don't
attempt to process further events on an already freed connection.
Change-Id: I0a9c7d8e3263c73440f7084dbb1792a4ca5038f0
Related: OS#3685
Depends: g#11704 (for libosmo-sccp)
commit 7028d7387efc2e0fbac403de075c4c9c2d310f80
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-08-13 16:09:24 +0200
jibuf: fix indentation in line inside conditional clause
Change-Id: I3cb356a4a13d53e7f88a5e4595899bb2eb510d20
commit 646d1c82042d8e04e810e8532e462159aab6387b
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-08-06 11:11:44 +0200
debian/rules: Don't overwrite .tarball-version
The .tarball-version file should contain the *source version* uniquely
identifying the git commit, and not the Debian package name.
With https://gerrit.osmocom.org/#/c/osmo-ci/+/10343/ there is a correct
.tarball-version file in the .tar.xz of the nightly source packages.
Change-Id: I8915ebbf7d3a64a9474e1aeb49b1d192a388ef53
Related: OS#3449
commit 635984c5e1fd13e3fa6e605fcd7fc7ee0dfef7da
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-08-01 18:02:04 +0200
link libosmo-netif against libosmogsm
The recently-introduced dependency to libosmogsm symbols needed
some explicit addition of linker flags to avoid user applications
to fail linking with
/usr/bin/ld: /usr/local/lib/libosmonetif.so: undefined reference to `ipa_ccm_id_resp_parse'
Change-Id: I07a28f8970b90f82736e2de783bafc9d2c5ea0e5
commit da5f41cdada843ede0a360dc72601fc2125d0677
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-08-01 13:25:16 +0200
Migrate from osmo_ipa_idtag_parse() to ipa_ccm_id_resp_parse()
In libosmocore Change-ID I1834d90fbcdbfcb05f5b8cfe39bfe9543737ef8f
we have introduced ipa_ccm_id_resp_parse() as a bugfixed replacement
of ipa_ccm_idtag_parse().
The main difference is that the returned "value" parts now have
a correct reported "length", whereas before this commit they all
reported a one-byte too-long "length" for each IE.
Let's use this opportunity to remove the copy+pasted
osmo_ipa_idtag_parse() function from the libosmo-netif codebase.
Change-Id: I4626d247626543e032593bf226b6c233f6678562
commit d5a35ed93284b306fd43a753f99cc2ae8ad1e996
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-07-26 17:29:46 +0200
fix strncpy bug in rs232.c
Change-Id: I2f3b7888acb4f25da22ffef4391e1d0831485483
commit 322dbbeaa29cb90c6917fa7e78a66b96b8ce3689
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-07-27 18:31:43 +0200
Bump version: 0.2.0.6-ac33-dirty → 0.3.0
Change-Id: Ic9bbe8427c44ef2a9ee02537f17821048f177cdd
commit ac33f6fbd2d55b0eb52b42e0d466be4c39914020
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-07-05 14:05:40 +0200
stream.c: Use non-blocking connect in osmo_stream_cli
When establishing a client-side stream connection via libosmo-netif,
we must using non-blocking connect if we want to avoid blocking/stalling
the entire process. The libosmocore socket API provides the
OSMO_SOCK_F_NONBLOCK flag for this. Make use of it!
Change-Id: I9bfcb39b5801a36ef32ca0d1f3eb8236687d7ed6
Related: OS#3383
commit e2fbd3dee43bb3d47c53514200650db41b4f5ef7
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-06-29 10:57:24 +0200
remove "channel" layer
The "channel" layer on top of IPA client + server was introduced in
2011 but never used in any osmocom program/project so far. Contrary
to the several other IPA multiplex related implementations in libosmo*,
it did not deal properly with segmented IPA messages, i.e. where a
single TCP segment (and hence recv/read call) does not contain a full
IPA message.
So rather than fixing it up and having yet another IPA related API in
our libraries, let's remove it.
Change-Id: I97c378750acb1637ee032fa88a968edf68d8979f
commit 7839556ca950f02e2dda48f8e10dd68e90266926
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-05-15 17:09:17 +0200
osmux: change log lvl of batch full to debug
This message is expected as all code filling batches call
osmux_batch_enqueue() and checks for error to know if it must tell the
user of the lib to call osmux_xfrm_input_deliver.
Change-Id: I3d8227f2281f6ca92fd2502d3e328765dc7ecfe9
commit 7b7562a713e6059a960f2e0b23a41f8c0028dd53
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-05-15 16:47:52 +0200
jibuf: Fix out-of-order seq queue around syncpoints
Fixes: OS#3262
Change-Id: Ib8c61dbe6261cf73d6efcd7873e23b7656117556
commit fab0df4913dbf6497de21fcaa2fcd8187ca64a31
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-05-15 15:37:05 +0200
tests: jibuf_test: Add scenario to show out-of-order bug
Related: OS#3262
Change-Id: I1e78cc44f8a04dcb983352b513f8de2574b2394b
commit bac671eda8f34918b7f71e6e42a3e92fac931efa
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-05-15 14:39:19 +0200
tests: jibuf_test: Set some functions as static
Change-Id: I3af6db3fd74d55c5e659132fc542f22478a55eb7
commit e38ee9b808970cd49663221cb823365ef18797d5
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-05-03 16:55:21 +0200
Bump version: 0.1.1.38-ef190-dirty → 0.2.0
Change-Id: Ic8a9e44b2f930fed024040777eab58699fdcaadc
commit ef1900151703e4d6b16cb434c3ae688fd7fddc55
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-04-28 13:36:40 +0200
osmux: Fix use of uninitialized memory in osmux_out_handle
In Change-Id: I2efed6d726a1b8e77e686c7a5fe1940d3f4901a7 we're adding a
new member to 'struct osmux_out_handle' which is not initialized.
Rather than initializing this single new member, let's do a memset()
over the entire osmux_out_handle at the beginnign of
osmux_xfrm_output_init().
Change-Id: I751e9414c6de2413a9f977e5ae5655ebfd114f45
Closes: OS#3219
commit df0ad6c1a4e23a96428e435af7ba54c2f367546b
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-04-19 12:29:45 +0200
osmux: Move examples and tests to use new output APIs
Change-Id: Ie69c427308eb7d81aedab7fbb71f1bdaf43f0275
commit e259c8ab18ce53bd58d022b2c6a193b4a2ec5b1b
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-04-18 19:10:20 +0200
osmux: Set Marker bit on osmux frame loss detected
Until this patch, we didn't notify in any way to the RTP reader when an
Osmux frame was lost. Instead, we updated the seq×tamp as if there
was no lost, and as a result the RTP reader would only see a steady
increase of delay every time an osmux frame was lost.
As the batch_factor for the lost packet is unknown, we cannot assume any
number of amr payloads lost, and thus we cannot simply increment seq and
timestamp for a specific amount. Instead, the only viable solution seems
to set the M marker bit in the first rtp packet generated after a
non-consecutive osmux frame is received.
The implementation may act differently with the first generated RTP
packet based on the first osmux seq number used for the stream. In case
0 it's used as first osmux seq number, M will be set depending on
request from original RTP packet having the M bit set. If it's not 0,
the first RTP packer will unconditionally have the M bit. That's not an
issue because it's anyway expect for receiver to sync on the first
packet.
Related: OS#3185
Change-Id: I2efed6d726a1b8e77e686c7a5fe1940d3f4901a7
commit 9452adcc33fe3daec6a2be25d4327203e4dee587
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-04-18 17:58:01 +0200
tests: Add osmux2 testsuite
This test is aimed at testing several specific scenarios related to how
osmux manages in/out of osmux/rtp packets over time.
Change-Id: I3bf59276424ea87c4e66a6ff46de1e3e9a06a904
commit dbf8e531927a39cb044c5ccdde54173d0f213a2e
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-04-18 13:58:46 +0200
osmux: Add new API osmux_xfrm_output_sched to fix rtp generation issues
With old implementation, in conditions with jitter we could end up
scheduling RTP generated packets from two consecutive osmux frames in an
interleaved way (from seq field point of view).
This new implementation should make it easier for any RTP
reader/playback to have better results in those conditions.
Old APIs osmux_xfm_output and osmux_tx_sched are marked as deprecated in
favour of the new one, which has a better control of generated RTP
packets. However, they are still usable despite the implementation changes
done to support the new API.
Related: OS#3180
Change-Id: I4e05ff141eb4041128ae77812bbcfe84ed4c02de
commit 6fb0f4de860245e7f176e65bc157ecae2afdc370
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-04-17 13:55:09 +0200
examples: use osmo_init_logging2
Change-Id: I7f1f4503f254931edeebfbadf3953efa7b20f85f
commit a29ea763ea3ebf5665682e5c165caa1a98efe6b3
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-04-17 11:56:29 +0200
Build jibuf_tool based on libpcap availability
Change-Id: I27cdb1b5175a5b02638e6d743b686bdf4b1be144
commit d5b68e2c70c5afe4f6b1248674ba8f4ae3baabd6
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-04-17 11:41:13 +0200
tests: use osmo_init_logging2
Change-Id: Icc84bbd53e1589e26e445e3460024e77162bd76f
commit e9e6200d84e9cdd56579a31faf4eaa8767230ed2
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-06-09 14:04:31 +0200
jibuf: Estimate src clock skew
Change-Id: Ifae633d53107417a8e2f9b0f200d2711db72d199
commit 14947b931bc532abd13fd46b6d23ba6e63f69d72
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-02-28 12:36:26 +0100
tests: jibuf_tool: Add seq.plt
Change-Id: I37bb3ab372b7ad7c3c1d09c8134827c932bf8bf8
commit 13c01178c5f1fabd94b699d326c19a9ae5b6c461
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-04-23 19:22:15 +0200
jibuf: re-sync clock out of sync timestamps
Change-Id: I33556b33d7549654442d9bdd7f31128792506652
commit 1ad87f26a188c11776fc8041c17ecd9a226168dc
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-04-19 17:25:09 +0200
jibuf: Take RTP marker into account
Change-Id: Ie142acfb45650e0af775f58226fd191beaf8178e
commit c70d2603482e638b15309d16531c1b42c140109d
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-06-08 17:06:58 +0200
tests: jibuf_tool: Add parameters to control size of buffer
Change-Id: I8a7fa39985f8d197e24c32cab80299aba2d03087
commit 0fa4eec275b0d87cd110dcd4f8bf029740f99f4c
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-04-19 18:58:00 +0200
tests: jibuf_tool: Add OSMUX support
Change-Id: I0f02da0329e6739ff340d31113161bb520b1b760
commit e32095033b4296cced98f57de2255645cc7b2474
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-04-19 13:30:10 +0200
tests: jibuf_tool: Improve jibuf_test to read pcaps
Change-Id: I7a13c823fb70e0adbc5fa0726fd66b15dc40014e
Signed-off-by: Pau Espin Pedrol <pespin@sysmocom.de>
commit 7787c8cce3f47e7de851e4092b27176a4cc7bd77
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-02-27 18:32:56 +0100
tests: jibuf_tool: Initial commit
Change-Id: I92307c8b1483dd488339771462290aae0ae5689a
commit ce820763c1c527856e8f75719b958de77d8c74aa
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-04-12 19:36:47 +0200
jibuf: Add initial implementation of Jitter Buffer
Change-Id: I9688ba9c4d5b733b9f29d0f15f73750f9271ef55
commit 5c962c2f3eb1c4e1497edf0f540006c76deb06fd
Author: Alexey <ananchenko163@mail.ru>
Date: 2018-04-13 00:35:56 +0300
Update README.md
Fixed "interface" double references
Change-Id: Icb41dc65dec56d6b8d8f23dfc9bbc2e85cf6dc3b
commit 23148b069f095e808dbf39adfa67eda71d690f7a
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-04-12 15:32:18 +0200
osmux: osmux_xfrm_output_pull: Improve checks and log of malformed packets
Change-Id: I143805bb5ee9f5e3ada46114e380a03ede80df9f
Related: SYS#4182
commit 9f521e10db64babb50057c3ede623bfbd2a51e95
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-04-12 16:35:09 +0200
tests: osmo-pcap-test: Fix pcap includes not found in old versions
pcap/dlt.h only exists on newer versions of libpcap. On older versions,
same defines are available in pcap/bpf.h, which in newer versions
include pcap/dlt.h, so we are always fine include pcap/bpf.h.
As a side note, there's a lots of comments in pcap/dlt.h stating that
those symbols used to reside in pcap/bpf.h but were moved there at some
point.
Change-Id: I824671a415eb3f35f480c934b9780ff13510011a
commit c71c9516ddff9d5e724401b97e8f134f3b5f1867
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-04-05 18:07:39 +0200
stream.c: osmo_stream_cli_open2: Remove wrong assumption in reconnect decision
Documentation of osmo_sock_init2 doesn't provide information of any
specific value of errno set/expected after running the function. It is
incorrect to expect a specific value of errno and looking at the
implementation it is actually not a good idea to check it.
If reconnect flag is set, let's reconnect always instead of looking at
errno to decide.
Change-Id: I25b33f4cdc496ae31ff240d445b9b2805091845c
commit 9d726d0e56665b4439bb4efe782be06be2e83ffb
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-03-05 20:51:03 +0100
jenkins.sh: use --enable-werror configure flag, not CFLAGS
Change-Id: I739f4562a96b7b6031075d47d94f46af7a37b4b4
commit 9f4a9232e791e60ca93a3a79f03efd8ca01cec9c
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-03-05 20:38:57 +0100
configure: add --enable-werror
Provide a sane means of adding the -Werror compiler flag.
Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"',
but that actually *overwrites* all the other CFLAGS we might want to have set.
Maintain these exceptions from -Werror:
a) deprecation (allow upstream to mark deprecation without breaking builds);
b) "#warning" pragmas (allow to remind ourselves of errors without breaking
builds)
As a last configure step before generating the output files, print the complete
CFLAGS and CPPFLAGS by means of AC_MSG_RESULT.
Change-Id: I68e4781ec5dfaf1dac46510a092a87e35691f082
commit ce439fc945afbefb9f1762cb6a4ee1b74cbd8ae7
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-03-07 13:13:17 +0100
osmux: Use correct log category DLMUX
Change-Id: I77f4593941207689f714d15304dcce40b21d4bd8
commit 525256a15a581daec7afd9edd65f10b827ff2f51
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-02-26 18:17:11 +0100
test: osmo-pcap-test: Fix clock drift while replaying pcap file
In the previous implementation, the processing time was not being taken
into account, which was implicitly added for each new packet to be sent,
which caused a steady incremental drift in the clock clearly visible
when analysing a RTP stream.
As it uses timespecsub, it depends on libosmocore Change-Id
I45fc993b9bb0a343763238bf463c8640f47b00f1.
Change-Id: I11cb9a63e16e829ccd4af1096b9f473c802d822f
commit f27fdf89dc52799e7c908493da2c9ccdf7b1d3c4
Author: Stefan Sperling <ssperling@sysmocom.de>
Date: 2018-02-22 19:34:19 +0100
add support for flushing and destroying a server-side stream
Introduce osmo_stream_srv_set_flush_and_destroy() which marks a
stream to be 'flushed and destroyed'. No new messages will be
received on this stream, and no new messages can be queued.
Once the Tx queue has been drained, the connection is destroyed.
The API user is given a chance to perform cleanup operations
in the closed_cb() callback for the connection.
The same mechanism will be added for client-side connections
in a follow-up patch.
Change-Id: I8ed78fe39c463e9018756700d13ee5ebe003b57f
Related: OS#2789
Suggested-by: Harald Welte
commit 2cbaf4139ae768ff5a79c79d389045b4ef4dd0e6
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-02-09 12:10:33 +0100
debian/control: Fix Vcs-Browser
Change-Id: I19049ccf6bfc100dbbeb81b80b9ff7f422ad232f
commit 3f93caea6e404618f2da49410e2f06e40aaac83e
Author: Max <msuraev@sysmocom.de>
Date: 2017-12-21 17:03:46 +0100
Enable sanitize for CI tests
Change-Id: I3a888a415698db5a11d74422f7ccb2d94126f56e
commit 3173ca7ac7e9c6c9e2ff9bb80a9d27a3c10c7608
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-12-14 15:53:15 +0100
contrib: jenkins.sh: Disable building doxygen for deps
Change-Id: I456b539ebdb86a6a27af0bec1d44d68b407ad912
commit c72be77aa330c968f9f1d624e38141b3c2e24323
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2017-11-17 03:29:51 +0100
osmo_stream_{cli,srv}_destroy: fix mem leak: empty msgb queue
On destroying a client or server stream, deallocate any msgbs that are still
pending in the queue.
In libosmo-sccp, the ss7_test.c in test_as(), messages are queued and were,
before this, left floating after the stream was destroyed, causing a sanitizer
memory leak. This patch fixes the leak.
Depends: Ia291832ca445d4071f0ed9a01730d945ff691cf7 (libosmocore)
Change-Id: Iaad35f03e3bdfabf3ba82b16e563c0a5d1f03639
commit b6e8d39417b217e9bbf396d50c3ef2a91a6c4054
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2017-11-20 14:23:25 +0100
gitignore: vim swp files
Change-Id: I0013625df95c5600479953e6f83b848efadb525a
commit 2547e87b94223d2a90057d87aa821f3745687196
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2017-11-17 01:43:36 +0100
add --enable-sanitize config option
Change-Id: Ie00859d981044d59b8114332884e3d7f6fc48ef7
commit 6d4acefb69b6a6f7fe29bb398ec617d7e3e01a71
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-11-17 15:12:32 +0100
stream: Avoid re-creating and leaking socket when unneeded
In previous implementation, if no reconfiguring is needed, a new socket
would be created without closing the old one, leaking the previous
socket. Instead, if we don't need reconfiguring, we return 0 as no
operation is required.
Change-Id: I6c1a7fff63e44840fb5e2bc7ace5e9a61e304987
commit bea215a565390009ddc79b830db334fa33cc7b3a
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-11-13 01:21:03 +0900
Add SPDX-License-Identifier + Copyright statements
Change-Id: I43bb1c4a889421907a1a08eb29c96f2330ab00ec
commit fb31c0953c90496a96627821a95806175e4a2dde
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-11-13 01:11:46 +0900
src/rs232.c: Fix accidential reference to GPLv3+ instead of GPLv2+
Change-Id: I5fa2696c5090994c417ca882c5225cbd7c1be2c7
commit 443f40a6bf8bd153625820e7e6541b283c236ded
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-11-13 01:10:45 +0900
debian/copyright: There are no AGPL licensed files left
Change-Id: I7d1bf1cdefea955b28e756419e7d90beb2535bd0
commit cc7f236a4a2398f3f618c430fc4e1616c9d940bd
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-11-13 01:09:52 +0900
debian/control: Fix upstream-name
Change-Id: Ic5f42a387525f7718097f4259bae6628b903a4ca
commit 1274b374301ed7087e5316be0544111ede07cc15
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2017-10-27 22:50:45 +0200
jenkins: use osmo-clean-workspace.sh before and after build
See osmo-ci change I2409b2928b4d7ebbd6c005097d4ad7337307dd93 for rationale.
Depends: I2409b2928b4d7ebbd6c005097d4ad7337307dd93
Change-Id: I6bdbd22b5f05ab75de2c6c777667bf1a63eb0b86
commit 5edefaf0e6ec3b0839fc0afd5f3bd7253df066ce
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-10-28 12:41:34 +0200
Bump version: 0.1.0 → 0.1.1
Change-Id: I731fce9fd10a586c10261b23ed0f0bbcb6f3eada
commit 358350468f8c31c9f05a41ede46627a47cce1f4a
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-10-28 10:20:59 +0000
Debian: The -dev package doesn't depend on any shared libraries
This fixes:
dpkg-gencontrol: warning: Depends field of package libosmo-netif-dev: unknown substitution variable ${shlibs:Depends}
Change-Id: Ic57cbc8a1876e6e5449e7dd4a73f269444dd67da
commit bdfe9682fef3606092fccc5b288f364fe22ec640
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-10-28 10:15:52 +0000
Don't link library against libosmogsm, we don't use any symbols of it
This fixes a related dpkg-shlibdeps warning
Change-Id: I0325e7a6dea5195f1634230930570bf4dfe3810c
commit c2c8b5c557650a1842029fd081ffddca6db65af6
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-10-27 20:00:39 +0200
Tag/Release Version 0.1.0
Short changelog:
* Add Doxygen documentation
* SCTP support in stream.c
* new udp-test-client and udp-test-server programs
* better / more verbose error handling in examples
* new osmo_dgram_tx_set_local_{addr,port}() functions
* use IPA definitions from libosmogsm, rather than repeating them
* encode RTP header M field of RFC3550/4867 in OSMUX header
* new osmo_stream_srv_link_set_nodelay()
* new osmo_stream_srv_link_set_proto()
* new osmo_stream_cli_set_nodelay()
* new osmo_stream_cli_set_proto()
* new osmo_stream_cli_set_local_addr()
* new osmo_stream_cli_set_local_port()
* new osmo_stream_cli_reconnect()
* new osmo_stream_cli_open2() with reconnect argument
* more vrebose osmux_snprintf()
* remove mistaken reference to AGPL in rs232.c
* fix memory leak in osmo_stream_srv_link_set_addr()
* add osmo-pcap-test for SLL and Ethernet
* extend osmux-test
Change-Id: Ibf75fcd6643351ce3946faa155ae1db8c33a5e35
commit c01033fcacd7b87cc9eb47279a5d40445d770c18
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-10-27 20:21:05 +0200
depend on new upstream libosmocore version 0.10.0
Change-Id: Id22c69f96e9b6058e4c32ffa5a77d224453711ce
commit 61b5b65debf407bb89da9df2b329d650f9526b29
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-10-27 19:57:37 +0200
some more Doxygen header text for datagram, osmux and stream module
Change-Id: Ied83e6b117a420d734a88e3aff925a874c3dd520
commit d8f2b38eb96592567398c69bafdb9b3ecb82432e
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-10-23 17:42:10 +0200
osmux_snprintf: Add doxygen doc
Change-Id: Idb3fcf25be9558bfc2f822352c07ebc2cb7d5caa
commit 77d08a67b53fe92856cdec9b3da91a980381d0cc
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-10-23 17:29:13 +0200
osmux_snprintf: Support different types of Osmux frames
Previous implementation handled all types as if they were Osmux AMR
frames. For Dummy frames, we account the padding but we don't care about
the padding content. For Signalling ones, as they are not in the
specification yet, it is better avoid using unespecified fields and
return an error because it's still not known how extra data will be
handled in the input msgb.
Change-Id: I48565472b47c2a0e5db50881fbb005537af8c70d
commit 05bb1c2b2ef02c340d098be50546a0fafaecdb4e
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-10-23 16:27:13 +0200
osmux_snprintf: Split logic parsing osmux header and AMR payload
The current code still expects to parse only AMR osmux frames, but that
will be fixed in following patches.
Change-Id: Ic2f4d1d3cc88af912bb43c8ecd90eacc6ff7190f
commit 1bfbf98f066dc1fa34bffb5377220323ea7aa802
Author: Max <msuraev@sysmocom.de>
Date: 2017-10-13 18:24:37 +0200
cosmetic: print textual error from recv()
Change-Id: Ic9557c6519b44b5985daf7d2d14ec063790441fb
commit a2b50809c766bfb1f94ac0fc7c76517e3e3a66ab
Author: Max <msuraev@sysmocom.de>
Date: 2017-10-13 18:16:03 +0200
cosmetic: relax UDP length check
Previously recv() returning 0 for UDP socket was considered as error
although it's legitimate return value for empty UDP packets. Relax the
error check to avoid confusing error messages.
The function behavior is the same:
* msg is not altered while receiving 0-length UDP packet
* return value is 0
The only result of the relaxed error check is the absense of error log
message for 0-length UDP packet.
Change-Id: I32e5fcbf5ed92cc923660ac59e6a37fd3f0703a7
Fixes: OS#2219
commit 8440357d4cc88479921350344e435ee9c5e4e0f1
Author: Max <msuraev@sysmocom.de>
Date: 2017-10-13 15:30:54 +0200
examples: add simple UDP client/server
In addition to showing basic UDP send/receive example, it helps to test
corner-case when dealing with 0-length UDP packets.
Change-Id: I08c0adf1cf9b6a6f1f7090b237d0497c2ec13cdf
Related: OS#2219
commit fae8559ff5ce825a874eeb33b2f1053430c07dc3
Author: Alexander Couzens <lynxis@fe80.eu>
Date: 2017-10-11 07:07:54 +0200
debian/rules: show testsuite.log when tests are failing
Change-Id: I3af7b50e3d3e0ba3eddace0e6d4e58c6cb98b9aa
commit c98bf1b880ec10924cd12477bf46ef5d0f959257
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-10-05 08:41:52 +0800
rs232.c: Don't #include <osmocom/abis/e1_input.h>
There's no need for the rs232 code to include a files from
libosmoabis. The only users of libosmoabis left now are the LAPD
examples:
examples/lapd-over-datagram-network.c
examples/lapd-over-datagram-user.c
Change-Id: Ie1bc0dd811362cec546486edc41d632740ed19cd
commit 59941982083f7f0d6ab11f7bbb42c297a3fb8d69
Author: Pablo Neira Ayuso <pablo@gnumonks.org>
Date: 2017-09-12 12:44:53 +0200
src: _snprintf() helper functions nul-terminate buffers, if possible
This patch inconditionally initializes the buffer we get to
nul-terminate it, whenever possible. It's a very simple solution to
catch three overly corner cases:
1) snprintf() returns -1, very much unlikely in practise.
2) msg->len == 0: In such case, I would expect this function is never
called with an empty message, but let's be safe in this case too.
3) If your buffer is empty, it doesn't nul-terminate the buffer.
Change-Id: I97e517f2d98e83894ea707c63489559302ff6bd2
commit 14af167a5553519d8164f4a21556888535eeefeb
Author: Pablo Neira Ayuso <pablo@gnumonks.org>
Date: 2017-09-04 20:35:36 +0200
osmux: fix buffer management mess in snprintf() calls
SNPRINTF_BUFFER_SIZE() looks too complex, previous version maintains two
different variables to account for the remaining space in the buffer,
one of them is always decremented based on what snprintf() returns,
which may result in underflow. These variables are swapped - not used
consistently - all over this code.
Replace this macro by a simplified version, with one single parameter to
account for remaining space. This macro also deals with two corner
cases:
1) snprintf() fails, actually never happens in practise, but
documentation indicates it may return -1, so let's catch this case
from here to stick to specs.
2) There is not enough space in the buffer, in that case, keep
increasing offset, so we know how much would have been printed, just
like snprintf() does.
Thanks to Pau Espin for reporting, and Holger for clues on this.
I have run osmux_test and, at quick glance, it looks good.
Change-Id: I5b5d6ec57a02f57c23b1ae86dbd894bad28ea797
commit 9c5f01e7b2cb1455314443ceaeb035326354d280
Author: Pablo Neira Ayuso <pablo@gnumonks.org>
Date: 2017-09-04 21:00:15 +0200
rtp: return offset in osmo_rtp_snprintf()
Instead of the result of the last snprintf() call.
Change-Id: I10066d73387be96a4e1f3349d700405beb138076
commit 03b84ec99ba591950b6598c682f6f7083c8cc2f5
Author: Max <msuraev@sysmocom.de>
Date: 2017-08-28 11:45:37 +0200
Use release helper from libosmocore
See
https://osmocom.org/projects/cellular-infrastructure/wiki/Make_a_new_release
for details.
Change-Id: I01b0aae741b83a3f17f1caf2b6837cf365a1709b
Related: OS#1861
commit e3189dc8c2161cafd465a59077a5fc2e0cf4ac4f
Author: Max <msuraev@sysmocom.de>
Date: 2017-08-25 17:24:22 +0200
Use value string check from osmo-ci
Change-Id: Id6048a69c9e0cc15010de643330aeb2a7271b2a6
commit e78605556770c19c7a2e52fbc67c1a89718ba9de
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-08-14 17:23:05 +0200
osmux: Slightly improve output format of osmux_snprintf
The buffer for osmux_test is increased as the former doesn't seem to be
able to cope with the whole output.
Change-Id: Ic838dd9d7ad89b4510ccfa58c0390c69a075b616
commit 7cca0da1cc58bd589989684147ae3a0cd5819902
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-08-14 17:19:55 +0200
osmux: Fix buffer overflow in osmux_snprintf
When running osmux_test on my PC, the process was aborted with a "stack
smashing detected" error.
Change-Id: I8a7cc422c181c0c5712ac8976a5be5f0ad44a9c0
commit 6032a35be84c87607e295e46f1e37d3dd4e5f1b1
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-04-20 12:44:04 +0200
tests: osmo-pcap: Allow different l2 pkts
Before this patch, ETH was assumed and other types were not supported.
This patch also adds Linux cooked packet support for L2.
Change-Id: Ie62fa0a8e45e1e141edb64b116dad185ad9c7a5f
commit 76c0acb149a03e6d7945e0ee4f4c6355381b7391
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-04-19 17:14:19 +0200
tests: osmo-pcap: Fix per packet timer
Before this commit, the gap time between 2 packets {n-1, n} was being
applied to {n, n+1}.
Change-Id: I715865c1edd1fc2ec9b024671d91eb72559cbdea
commit 243a3b0372fe738b01c2d32d6f6cb7b7c99a1180
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-07-05 22:15:11 +0200
contrib: Enable -Werror by default
Change-Id: I045536c21d7a0fa2fc23258c727d67bedf176ece
commit 728c2df7966c0ca0b6c3064972a14684910375c4
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-07-13 21:29:30 +0200
rtp.c: Fix print format
Fixes compilation warning
Change-Id: I0146a19bf852c9e27d265a098dc9d7a337424e10
commit baff9c752e3e38581e32cc97bdb510394a34b608
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-07-10 15:00:00 +0200
jenkins.sh: Proper error message if local environment isn't set up
Change-Id: I79c2302365824d9c8783dadfa378c8eaa07e2ee7
commit a6c6fa3a9a3195b35e7d2c93421f2b2eb46bac54
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-07-05 22:12:11 +0200
configure.ac: Use -Wall in C(PP)FLAGS
Change-Id: Ia1d7e99541089a92e6bc17798a94ac756047aeba
commit b049f39f317e1cc748e7196460aef11948f042f0
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-07-05 22:33:29 +0200
configure.ac: Add --disable-doxygen flag
This flag, when set, allows to unconditionally disable doxygen
documentation generation, even if doxygen command is found.
Change-Id: I16b3502be3e32274f548da6a2a0b0363dd3bfe5d
commit 57b5f824911c0ba6b2a8e1fecaa4dc98ec4b21f6
Author: Pablo Neira Ayuso <pablo@gnumonks.org>
Date: 2017-06-07 18:38:21 +0200
src: use osmo_timer_setup()
Use new function available in libosmocore to set up timers. Compile
tested only.
Change-Id: Id3dd32102c7362f3b280d2c058c2decebccb357a
commit 31b1dbd894d6c4b1f1abf38b2816cca920e894f9
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-04-27 10:59:31 +0200
somo_stream_srv_fd_cb(): close socket if NODELAY fails
We didn't check for cases where setsockopt_nodelay() fails. Let's check
for that and bail out + close the socket.
Change-Id: I0adbc4cec35be7c36bdf01d4d8fefd6097e9be5d
Fixes: coverity CID#166970
commit 56add1e78064698fdf909cf000d413357303af8a
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-04-15 23:17:38 +0200
stream.h: Add missing stdint.h include
This header uses uint16_t, which is provided by stdint.h.
Change-Id: I399e2986c9d8cb5b3dd31673a6b4bf63070a4770
commit 4e93766a4bcdfc69869f635cc99e7301ba0ac43b
Author: Holger Hans Peter Freyther <holger@moiji-mobile.com>
Date: 2017-04-10 16:53:32 +0800
misc: Call the variable ctx like in all other places
We couldn't figure out what "crx" as supposed to mean and assume
it is a typo. Fix the code and call it ctx, this is fixing the
API documentation as well.
Change-Id: I27ed1178fdbbcf3fc0e1070dc19b4ecf9a327a04
commit a18caad5fd6131b1d8474154e7fefd9c462485bd
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-04-24 10:09:26 +0200
osmux: Fix delay between RTP packets
AMR frame contains 160 samples at 8000Hz -> 20 ms long
Change-Id: I36dc69f9caf591dd1b578bc914a2ce426c7f2813
commit 2c83b9a0adbb3c364409f2917b7a449c9966fee6
Author: Max <msuraev@sysmocom.de>
Date: 2017-04-27 11:32:38 +0200
deb: add missing dependency on doxygen
Attempt to fix OBS nightly by adding explicit dependency on doxygen,
similar to other libosmo*
Change-Id: I9cfc94a115c19eedf0923caacd17d1521b4c8fe4
commit 3460ad7f31fb1daa529662a1b2ac4d4b0f5e9a7e
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-04-26 16:00:03 +0200
osmux: Use osmo_gettimeofday for testing puroposes
This way we can use fake time and osmux_test take 700ms instead of
>2sec to run.
Change-Id: Ic39cab74400aca8262a00c0d06884230b1a15ca3
commit e98afe5808176efb60298a2f764e8e11efaf580b
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-04-25 17:20:38 +0200
osmux: Add RTP marker bit support
According to RFC4867 (RTP payload format for AMR):
"The RTP header marker bit (M) SHALL be set to 1 if the first frameblock
carried in the packet contains a speech frame which is the first in a
talkspurt. For all other packets the marker bit SHALL be set to zero (M=0)."
This information bit provides a way for the receiver to better
synchronize the delay with ther sender.
This is specially useful if AMR DTX features are supported and
enabled on the sender.
Change-Id: I0315658159429603f1d80a168718b026015060e9
commit a67c47cab412b631c19e3f32167b9f5a0edc39ba
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-04-12 16:11:50 +0200
osmux: Check batch_factor overflow in osmux_batch_enqueue
This commit should fix a bug present if for instance batch_factor < 8
and osmux_batch_enqueue is called from osmux_replay_lost_packets and
enough packets were lost from last received packet.
Change-Id: I5d643810949aeca4762f0cad05eed534d35087f7
commit a15d00ca578a57a73e7612aaa9bdc02505b6cd12
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-04-25 17:27:13 +0200
osmux: use uint8_t everywhere for batch_factor
Change-Id: I9fcc8e94b2fcd843b10cb3f8f009f2348eb3a4af
commit dafdb5ef8ce551ab212a81aac0be009dba9cca02
Author: Max <msuraev@sysmocom.de>
Date: 2017-04-25 13:24:46 +0200
Fix debian packaging
* add separate -doc packages
* fix dh_install override
* add conflict with previous version
Change-Id: I2781c800d39923c5541bac00f00cb128f4acf008
commit c108c9db969c4d4abaccc88419b4ac0c44957365
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-04-17 16:05:22 +0200
SCTP: Don't enable sender_dry_event for SCTP, as it breaks Linux SCTP
Enabling sender_dry_event in SCTP_FLAGS breaks reliable delivery of DATA
chunks to the scoket user on Linux. Let's avoid enabling that, while
still enabling various other interesting events.
See https://bugzilla.redhat.com/show_bug.cgi?id=1442784 for all related
details.
Change-Id: Ib616cd07a6044ca2ee7e05093b22df3369c62b56
commit c200a956157d6ddf0ccdc6b167363c0a13536416
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-04-16 23:34:28 +0200
stream.c: Fix SCTP_NODELAY setting
We were using the wrong variable when setting the SCTP_NODELAY,
resulting in the setsoctkopt() fialing.
Change-Id: Ic04cb8bb5ff41f177f7f5b7f7e2a2ecc686dd4c0
commit d8348ddafca54eee7cc001abf49be63db138b4cf
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-04-15 16:06:56 +0200
netif/ipa.h: Don't redefine 'struct ipaccess_unit' from libosmocore
'struct ipaccess_unit' is defined in libosmocore/gsm/ipa.h, we shouldn't
re-define it here. This entire IPA code duplication accross multiple
libraries and programs is a big mess.
Change-Id: If378a088c741df540befb928a5557fc62dea954a
commit 719d1a38c67afb5e896d35bccb2cc3f922872ec8
Author: Neels Hofmeyr <nhofmeyr@sysmocom.de>
Date: 2016-11-26 14:51:45 +0100
osmo_stream_srv_fd_cb(): don't leak socket FDs on errors
So far we seem to assume that the accept_cb does all handling of socket
fd cleanup. However, there are cases where there is no accept_cb set,
the accept_cb returns error, or an earlier sctp_sock_activate_events()
or the activation of non-blocking mode fails.
For those cases, close the socket and return an error code.
Fixes: CID#57915
Change-Id: I3a3ce9194ab7ca5c1921fc79c2a1c9e10a552cf0
commit a7d7dd220cd8a94ca6ee341620f0cd40815ec3b7
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-04-14 10:49:18 +0200
ipa.h: Don't redefine what libosmocore already defines
Change-Id: Ibd81efc1dc61b8c2019d55a8fa6e3bb99b5acb20
commit 73a44d23488d02825825581bcd962b0757a7a26a
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-04-12 15:06:37 +0200
stream.h: Add missing stdbool.h include
Functions introduced in 9ec26583cd807e0aeaa3b9de927f3d8a768c3a71 are
using the bool type without referencing stdbool.h as include file.
Change-Id: I736cb04629d516c10c7d5f42f792ed3d5ae6658f
commit 5ae42bca913c94b7f93fdc6a72f0aff885f5d794
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-04-12 12:08:45 +0200
SCTP: Fix PPID byte width
In a659590e29412588bca2243b8329e82286244b00 we fixed endianness issues
with the Stream ID field, but at the same time mistook the PPID field
for 16bits. In reality it is 32bits, and hence our 'htons' is rendering
wrong PPID values.
Change-Id: I1b60523044835ee630dba9a43d26af4f1ebd1ced
...