commit 176a1fbab6ae45eb1c60e3d8b263b0765759e1da
Author: Harald Welte <laforge@gnumonks.org>
Date: 2019-01-19 22:20:47 +0100
Bump version: 0.5.1.20-de57 → 0.6.0
Change-Id: I417065deb06ac7e8b3b8468b88cc803a41098c2d
commit 961776a2f97cb6d2877939f1cd1a21545ce8c57d
Author: Stefan Sperling <ssperling@sysmocom.de>
Date: 2018-12-06 13:09:48 +0100
log IPA tags correctly
Due to apparent copy-paste errors, wrong values were being
logged for IPA tags in ipa_bts_id_resp().
Fixes: 4c57eef663e870247cb7a72130a50750317a44b9
Change-Id: I29a0401db0760219b9b9176709a88d589312261b
Related: OS#3355
commit de5758d307f6794b4126c6cf5251a5c5a8b9f193
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-11-12 17:00:22 +0100
osmo_ortp: Log domain and fix strings without endl char
Change-Id: Ib6df0df04cd6ba342753c84398274d04917ace40
commit 4179207e0ec2833c649174aef5b32b54431f23a8
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-10-03 13:18:37 +0200
e1_input.h: Set correct type for input_signal_data->link_type
link_type field holds values from link->type as set in
e1inp_int_snd_event().
Change-Id: Iaa33b793f89f2d16c9d949503c5ecc195bbcd2a4
commit b5cfc6b019dbb31ceb52e8747c422bbaa0f60ac9
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-10-02 21:22:18 +0200
ipaccess: Simplify handling of ipaccess e1line ts
Handle encoding specifics behind a macro to make code easier to
understand and follow.
Change-Id: Ibf251673bff95b7a0b066b19ef4dc6c0f94fff6b
commit dd95eb64800945a564d45ccb8d74fcca6daf568e
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-10-02 20:05:28 +0200
ipacces: Log correct trx_nr during IPA GET
dev->trx_id points to a structure used for whole BTS and doesn't point
to related TRX ID, which is encoded in priv_nr.
Change-Id: I00b01790990c8d21fdbe0f5750fa02f13ddb2009
commit 0d7d0b0a861c1abeb6a4852c914bc0a483dc9744
Author: Stefan Sperling <ssperling@sysmocom.de>
Date: 2018-09-20 17:34:31 +0200
ensure unix socket paths are NUL-terminated for bind/connect
The unix(7) man page recommends that sun_path is NUL-terminated
when struct sockaddr_un is passed to a bind() or connect() call.
Non-NUL-terminated paths only need to be dealt with at the
receiving end of a UNIX domain socket.
Commit b24efa5 erroneously assumed otherwise.
Change-Id: I9beecfa500db75cb679b1edcc352c893bf098b13
Fixes: b24efa551dc91e177c5cb8da674e9f8432d52dc9
Related: OS#2673
commit 47e9e63bd54d31ca1d88ffd97da5be1caf3b4ae4
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-09-04 17:33:06 +0200
debian: Conflict libosmoabis6 with libosmoabis5
In previous commit 9540f59b1daeac36d71b20ac9cefe15019d6277c, libosmoabis
packaging was fixed to match its contained major lib version.
However, systems using nightly may run into issues when upgrading since
now libosmoabis6 in repo tries to overwrite libosmoabis5 in their system
and fails. By using Conflicts + Replaces it should do it now without
erroring.
Fixes: OS#3365
Change-Id: If98ae21670f13554da5aa46fe30741d56631fd8c
commit b24efa551dc91e177c5cb8da674e9f8432d52dc9
Author: Stefan Sperling <ssperling@sysmocom.de>
Date: 2018-08-28 14:03:41 +0200
Properly deal with sockaddr_un socket path length limitations.
When parsing the configuration, reject a socket path which
exceeds the maximum size supported by the operating system.
In unixsocket_line_update() stop copying the line's socket path to a
local buffer. The path will be copied again in osmo_sock_unix_init().
Both changes are portable; we don't assume any particular socket
path length since the size differs between implementations of Unix,
and we rely only on information from the generic sys/un.h header.
Change-Id: I36344805a825f5d0e0c9d218d438d8fd985ed9ca
Related: OS#2673
commit 9540f59b1daeac36d71b20ac9cefe15019d6277c
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-08-30 14:21:58 +0200
debian: Fix libosmoabis soname package version
LIBVERSION for libosmoabis was increased during v0.4.0 release, but
didn't update the debian package name accordingly to match major.
Change-Id: I7ead154d72e6dadf795414c47fe276edadd08580
Fixes: OS#3365
commit ed122f3c25070252c44819767adf67bf3b006260
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-08-28 18:25:02 +0200
ipaccess: Allow passing return code in e1inp_line_ops->sign_link()
Change-Id: Ia83eead3622d86f55c1dc5e91acc78dde73a0367
commit 7ad2b15bc767f471ae12d4d72b5c734bde163d2a
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-08-28 17:37:59 +0200
ipaccess: Return -EBADF when closing socket in ipaccess_bts_read_cb
As we are closing the socket, there's no need for lower layers to
continue handling it, so let's return -EBADF.
Change-Id: I961b0ef7e598a09ce48a83038c0d90a415e0e11c
commit 082876bb65341d05263829664d3de0aa8dd4a874
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-08-28 17:53:38 +0200
ipa: Allow signalling fd destroyed in ipa_server_conn_read
Similar to what we do in other osmo_fd cb, check for read_cb returning
-EBADF and in that case don't attempt using the osmo_fd anymore, either
because the fd was already closed (no need to then signal WRITE) or
because osmo_fd struct itself has been freed.
Change-Id: I4b968b72285f23a9552519cea67398a43d5003d2
commit 2775798edb2ea72dbe683cf61700b61426e67bf5
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-08-28 17:32:29 +0200
ipa: Allow signalling fd destroyed in ipa_client_read
Similar to what we do in other osmo_fd cb, check for read_cb returning
-EBADF and in that case don't attempt using the osmo_fd anymore, either
because the fd was already closed (no need to then signal WRITE) or
because osmo_fd struct itself has been freed.
Change-Id: I0e449a2bdf7f0411feeccd262cd731ca6fba3fc1
commit 3750dea96852b453029f91d4b3a66912745290d9
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-08-28 17:49:29 +0200
ipa: Simplify code in ipa_server_conn_read
By doing this change we remove a duplicated error code path and thus
avoid having to maintain an extra code path with function pointers.
Change-Id: I5bce9f92209cc2fb37b78792e34f7898c71d2327
commit 493c8e6008f3cd27366b0a007f3b96a05e3df75a
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-08-28 16:46:39 +0200
ipa: Simplify code in ipa_client_read
By doing this change we remove a duplicated error code path and thus
avoid having to maintain an extra code path with function pointers.
Change-Id: Ic044894980ae2b882d99eb30d9df50066671d8f3
commit fe6731181c7db6455490c62b3e3f3f051fbdb09f
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-08-24 17:43:45 +0200
ipa: don't crash on missing IPA ID GET message
ipaccess_bts_read_cb() only initializes signalling links if it has received an
IPA ID GET message on it, and so far happily accesses the uninitialized
sign_links list anyway if it hasn't.
Reproduce: simply don't send an IPA ID GET message when connecting to an IPA
server run by libosmo-abis, then continue to use the link --> segfault.
Fix the segfault: make sure that the e1inp_ts' type has been set, i.e. that
e1inp_ts_config_sign() has been called and the sign_links llist is initialized,
before calling e1inp_lookup_sign_link() on it.
../../../src/libosmo-abis/src/e1_input.c:511:2: runtime error: member access within null pointer of type 'struct e1inp_sign_link'
../../../src/libosmo-abis/src/e1_input.c:512:11: runtime error: member access within null pointer of type 'struct e1inp_sign_link'
ASAN:SIGSEGV
=================================================================
==5702==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000038 (pc 0x7f28a379ea34 sp 0x7ffd7d8933f0 bp 0x62e000000a98 T0)
#0 0x7f28a379ea33 in e1inp_lookup_sign_link ../../../src/libosmo-abis/src/e1_input.c:512
#1 0x7f28a37b97d4 in ipaccess_bts_read_cb ../../../src/libosmo-abis/src/input/ipaccess.c:778
#2 0x7f28a37b0277 in ipa_client_read ../../../src/libosmo-abis/src/input/ipa.c:76
#3 0x7f28a37b0277 in ipa_client_fd_cb ../../../src/libosmo-abis/src/input/ipa.c:139
#4 0x7f28a2ac1a34 in osmo_fd_disp_fds ../../../src/libosmocore/src/select.c:217
#5 0x7f28a2ac1a34 in osmo_select_main ../../../src/libosmocore/src/select.c:257
#6 0x444ba3 in bts_main ../../../../src/osmo-bts/src/common/main.c:364
#7 0x7f28a17ddb44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)
#8 0x405e54 (/usr/local/bin/osmo-bts-trx+0x405e54)
Related: OS#3498
Change-Id: I2487ca37a0fe9aa56733f66bcad9dcf91fc11144
commit 67902bbeb973b9da8a390bb5aacb3dba7ece1e15
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-08-23 14:35:08 +0200
ipaccess_rcvmsg: Fix bug introduced in previous commit
Commit 56ae85fd524d5c9e8b61ccb19e81b16fbc726bb0 modified code in
ipaccess_rcvmsg to use osmo_fd_setup. During this change, a "|="
operator was converted to "=". Fix this change by manually ORing old and
new values passed to osmo_fd_setup.
Change-Id: Ie59072f07ca50d853c413fa038e447dcdee30a76
commit 56ae85fd524d5c9e8b61ccb19e81b16fbc726bb0
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-08-22 13:11:19 +0200
ipaccess: Use osmo_fd_setup to set up callbacks
We have a public API in libosmocore, so let's use it istead of manually
filling each struct field.
Change-Id: I09479c3d5b0b9bd69a56c080b8c533a32824cc66
commit a60f5e13b6d21b15d98316855c2834552bfe4606
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-08-06 11:10:29 +0200
debian/rules: Don't overwrite .tarball-version
The .tarball-version file should contain the *source version* uniquely
identifying the git commit, and not the Debian package name.
With https://gerrit.osmocom.org/#/c/osmo-ci/+/10343/ there is a correct
.tarball-version file in the .tar.xz of the nightly source packages.
Change-Id: I4ce87d474687b61bc2104a02015e954425736123
Related: OS#3449
commit 82eb55e5a1a7520ecec694b900b651d2908d3bd1
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-08-01 13:22:55 +0200
Migrate from ipa_ccm_idtag_parse to ipa_ccm_id_resp_parse()
In libosmocore Change-ID I1834d90fbcdbfcb05f5b8cfe39bfe9543737ef8f
we have introduced ipa_ccm_id_resp_parse() as a bugfixed replacement
of ipa_ccm_idtag_parse().
The main difference is that the returned "value" parts now have
a correct reported "length", whereas before this commit they all
reported a one-byte too-long "length" for each IE.
Change-Id: Id4c9ff821a43a37cbacce905d44fee43d1b2c879
commit 4c57eef663e870247cb7a72130a50750317a44b9
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-07-26 17:28:24 +0200
fix strncpy bugs in ipaccess.c, ipa_proxy.c
Change-Id: Iad53b603521c0a8f4857bd87dca777ba8e875cde
commit 026ff4574daedcf91a474f9bc67e90e8537a9d86
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-07-27 18:15:19 +0200
Bump version: 0.5.0.10-a210-dirty → 0.5.1
Change-Id: I9a606d5d3f9ce6baf99e69d60529332a460a9504
commit a2106844330221611fc8e2debb25f87dee56bcfb
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-07-24 15:00:11 +0200
e1_input.c: Replace '.' in counter names with ':'
The '.' is illegal character in counter names, as they are exported
via CTRL interface, where '.' has a special meaning that cannot be
used by strings comprising the variable name.
Change-Id: I730d1acdd5562cd2c1758ceee31193010b14337d
commit e7761c6f6fb5e4b2fa049f1172a259652ac3692d
Author: Philipp Maier <pmaier@sysmocom.de>
Date: 2018-06-05 16:13:58 +0200
Revert "ortp: enable scheduled mode on rtp socket creation"
We discovered that enabling the scheduler caused a segfault on the
ARM build of osmo-bts. So we have to revert the following two changes:
Change-Id I3a63c23f5ede47773b6a249a48ecebd5d3b45ace
Change-Id I4b8f0349d5503bbe53745cc8903beb26f149f219
This reverts commit 5a236ce1d414625476d0c0f652ecbe0eb2bbeaf1.
Change-Id: Ic81062d79a304038a50658b955f7d05edb3fa28e
Related: OS#3299
commit 05de362c81642059becbd1c2a55772fa2708f6a0
Author: Philipp Maier <pmaier@sysmocom.de>
Date: 2018-06-05 16:13:48 +0200
Revert "ortp: make sure the ortp scheduler is started"
We discovered that enabling the scheduler caused a segfault on the
ARM build of osmo-bts. So we have to revert the following two changes:
Change-Id I3a63c23f5ede47773b6a249a48ecebd5d3b45ace
Change-Id I4b8f0349d5503bbe53745cc8903beb26f149f219
This reverts commit 7632278ea36c25eaa0d8e35fa0ee102ec05dc802.
Change-Id: Ie375b9eb0dc8ec4f8d4ca12940a7bc5dfc1f6235
Related: OS#3299
commit 5a236ce1d414625476d0c0f652ecbe0eb2bbeaf1
Author: Philipp Maier <pmaier@sysmocom.de>
Date: 2018-05-30 14:36:55 +0200
ortp: enable scheduled mode on rtp socket creation
we use some functionalities of libortp that require to use rtp sessions
with the scheduled mode enabled. Since we do not enable the scheduled mode,
yet, we receive error messages in the log that complain about a non enabled
scheduled mode.
- Turn on scheduled mode using rtp_session_set_scheduling_mode() when
osmo_rtp_socket_create() is called.
Note: this patch is related to chane:
I3a63c23f5ede47773b6a249a48ecebd5d3b45ace Unfortunately we observed a
segfault with ortp version 0.25.0 (ARM), which seems to be related to an
unintialized scheduling mode. We expect this patch to fix the problem.
Change-Id: I4b8f0349d5503bbe53745cc8903beb26f149f219
Closes: OS#3299
commit c81b68f3e83bc95c71b3078838b2f70abe39927f
Author: Philipp Maier <pmaier@sysmocom.de>
Date: 2018-05-30 11:00:21 +0200
ortp: detect ssrc changes immediately
libortp detects an ssrc jump using a packet count thresold. This
threshold is set to 50 by default. This means that libortp has
to see 50 rtp packets with the new SSRC before it accepts the
new stream. In our application we want to detect the changed
SSRC (Handover) as fast as possible. So we should change the
threshold to zero.
- use rtp_session_set_ssrc_changed_threshold() to set a thresold
of 0 packets when osmo_rtp_socket_create() is called.
Change-Id: Id88c2c44d29a409affc2e47fdb932e1187020593
Related: OS#3299
commit 28eeb6bc9365bbe47125775fcb1f696317c22466
Author: Philipp Maier <pmaier@sysmocom.de>
Date: 2018-05-30 10:52:41 +0200
ortp: reset rtp session on SSRC changes
When libortp detects a timestamp jump, we resynchronize the session
in order to restore proper rtp frame reception. However, we do not
resynchronize on an SSRC change. An SSRC change usually indicates
the change of an RTP stream source, which is a much more profound
event than a timestamp change, so we should even reset the session
on SSRC changes.
Also, not resynchronizing the session on an SSRC change causes
problems when the jitter buffer feature is used. In those cases
it takes libortp a long time until it finally detects the timestamp
jump and the session resyhcornization happens late.
- reset the ession on SSRC changes by calling rtp_session_reset()
Change-Id: I8688a55cd20d0e14493c357db80754851e12f2fb
Related OS#3299
commit 7632278ea36c25eaa0d8e35fa0ee102ec05dc802
Author: Philipp Maier <pmaier@sysmocom.de>
Date: 2018-05-29 16:04:41 +0200
ortp: make sure the ortp scheduler is started
the function osmo_rtp_init() is initializing ortp at the start of the
application. However, it does not start the scheduler of ortp, which
leads into error log messages in some situatios.
- make sure that ortp_scheduler_init() is called with osmo_rtp_init()
Change-Id: I3a63c23f5ede47773b6a249a48ecebd5d3b45ace
Related: OS#3299
commit b0162077da4d2b60c9006173c11bfab5a0369164
Author: Stefan Sperling <ssperling@sysmocom.de>
Date: 2018-05-22 18:19:00 +0200
fix double-free/use-after-free of pointers in struct e1inp_line
Ensure that pointers in cloned e1inp_lines point to valid memory.
Some members of struct e1inp_line can simply be deep-copied.
Use talloc reference counting for pointers to objects which may
be shared between clones (driver-private state and counters).
Prevents double-free bugs, e.g. when multiple links referring
to the same line are closed.
Also, do not forget to unlink struct e1inp_line's counter group from
the counter list. Fixes use-after-free in rate_ctr_timer_cb() during
osmo-bts shutdown.
Change-Id: I9f4724b4a5a064801591e9acf4f2fd1db006d082
Related: OS#3011
Related: OS#3137
commit 7edc25d9d523b6d16cbf2becd365d83d1da61de9
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-05-23 14:57:03 +0200
ipaccess: Avoid using released line and bfd in ipaccess_fd_cb
Related: OS#3282
Change-Id: I52faa9e6717137a7dab9c4e006eaa50b7367fc3e
commit cfe2260c008df3a730d7b59dcf58f36783e73f66
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-05-23 14:50:43 +0200
ipaccess: ipaccess_rcvmsg: Drop unneeded memcpy
Those values are not used anymore, since the old bfd is unregistered and
the values for the new one will be overwritten by osmo_fd_register.
Change-Id: I7ac74843cbed920a2fdc6ade7aef4d4de905939a
commit 7b89f12e66a280746fc8e7906505b2d769d19706
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-05-03 16:12:04 +0200
Bump version: 0.4.0.21-60fd-dirty → 0.5.0
libosmotrau library version in debian package was wrong, fix it while
releasing.
Change-Id: I399618c7353a4150e3d571758b522dd2e9d9724f
commit 60fd2a0e85efaede3401f89e6ea09191e80362aa
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-05-02 19:36:34 +0200
git-version-gen: Check first for new tag format
Tags starting with "v*" are old ones. We first want to check for the new
ones, otherwise the wrong tag is selected as the last one.
Change-Id: Ic39bed2fcf7e3ccb6a83e2999d29d129e07c1a84
commit c04d8d2274a2d081000b57be307a5ad88e937bdd
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-04-17 14:42:44 +0200
use osmo_init_logging2
Change-Id: Iab9d111aba8f9b423e6a541e928f68b38d561067
commit 43b5b69bb890441c7285541b36ef986063eab8cb
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-04-10 18:15:48 +0200
configure.ac: Fix condition check for RTP_SIGNAL_PTR_CAST define
While building libosmo-netif on a system with an old ortp (0.22), it
was seen that warning related to RTP_SIGNAL_PTR_CAST not being correctly
selected were being printed. The compilation didn't fail there as
expected because the issue was being handled as a warning instead of an
error, so the void* ptr case was always being selected.
Change-Id: Ib5e7569e68fdb921c63e0c12e20e73aafbebda46
commit db0700a5a33bb3988e3c1d43dbe58e0e1fa7e836
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-04-06 13:18:48 +0200
e1_input.h: Remove dead declaration of unexistent API ipaccess_setup
The function was removed long time ago in
af8ed983ffa1f750e3972e0fb850c16249943543.
Change-Id: I34debe01d1d8b6f4420354666d2a25807dacc25c
commit 49917c129b1456585258b0ebe89a513ecef823a8
Author: Stefan Sperling <ssperling@sysmocom.de>
Date: 2018-03-22 20:19:56 +0100
preserve 'when' flags of new osmo_fd in ipaccess_rcvmsg()
ipaccess_rcvmsg() disposes of a temporary osmo_fd structure after
the RSL link comes up. It copies data from its temporary osmo_fd
to the new one returned by sign_link_up(). However, in doing so,
it clobbered the 'when' flags, which could differ between the two
osmo_fd structures.
For instance, BSC_FD_WRITE could be set on the new osmo_fd but
not on the old one, in case sign_link_up() has already enqueued
outbound messages using the new osmo_fd.
Because of this behaviour, a patch committed to osmo-bsc to address
issue #2719 did not work as intended and had to be reverted.
After this change, that osmo-bsc patch should work as intended
and issue #2719 can hopefully be resolved.
Change-Id: I52f7c903212b38e9c87e4d45e52b231b6f1ae9f5
Related: OS#2719
commit d3b8b69977207235056f6033e5828796e5620049
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-03-05 20:50:38 +0100
jenkins.sh: use --enable-werror configure flag, not CFLAGS
Change-Id: I487ab6f2e391aa57404725de2c8ab5447ca9f725
commit bb83e6f7eb7fa3910586a182ed93d69a850e3e21
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2018-03-05 20:37:13 +0100
configure: add --enable-werror
Provide a sane means of adding the -Werror compiler flag.
Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"',
but that actually *overwrites* all the other CFLAGS we might want to have set.
Maintain these exceptions from -Werror:
a) deprecation (allow upstream to mark deprecation without breaking builds);
b) "#warning" pragmas (allow to remind ourselves of errors without breaking
builds)
As a last configure step before generating the output files, print the complete
CFLAGS and CPPFLAGS by means of AC_MSG_RESULT.
Change-Id: I20d5f18cf05c9e277d914ada259a95187b73fe39
commit 61460fd6431d6ea62752d74ad05425f132d7abbe
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2018-02-20 20:21:13 +0100
contrib: jenkins.sh: Disable doxygen in libosmocore build
Change-Id: I52fc3931ef072075561858bb7173f58a8503e499
commit f446367a631cafd597bffc2cd39e9ba7718055c6
Author: Max <msuraev@sysmocom.de>
Date: 2018-02-13 15:17:27 +0100
IPA: log remote address
Wrap IPA logging to always print peer's address to simplify
troubleshooting.
Change-Id: I19ebaea45812aad6b3d3480cac0f1f833daf428d
commit f2a1607e27fe7849bc5e3f4ddc41e35ef056bd04
Author: Harald Welte <laforge@gnumonks.org>
Date: 2018-02-09 12:09:41 +0100
debian/control: Fix Vcs-Browser
Change-Id: Ibcc861fe2125ee81097d0209b95dcbdc98c819a8
commit 7139352e67acf79fd94707ad7a965244384fdb04
Author: Max <msuraev@sysmocom.de>
Date: 2018-01-08 15:42:00 +0100
cosmetic: update ipaccess_bts_handle_ccm()
* mark internal function parameter as const
* log unit IDs
Change-Id: Ifcf8baf4bf5670efaa8689ca7386597fe2797bda
commit d1dd22c38e86f123c8f9a93c2789deafdfcb9265
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-12-03 10:00:16 +0100
Add a new osmo_rtp_set_source_desc() function to set the RTCP SDES items
This allows the users of libosmotrau to set the content of the SDES
items to something more useful than their compile-time defaults.
Change-Id: Ice794f9e0c6caeea1c67520c12efbfa375d1fb82
Related: OS#2701
commit 2d4888dd08f5f340019ace5050a64a85dec57400
Author: Alexander Couzens <lynxis@fe80.eu>
Date: 2017-03-12 20:39:52 +0100
unixsocket: fix a potential string overflow
Change-Id: I8e3ec741247d728232f8c07c94eb63f068597d80
Found-by: coverity
commit 2e05f883f92909bb1a29b9b912d5c24200394839
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2017-11-17 01:43:36 +0100
add --enable-sanitize config option
Change-Id: I59fea4a7199ca6aa71710d3aca0b25425df7d346
commit 323d39d784417b5582098d6a27b24f94bb2e1d12
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-11-13 01:09:21 +0900
Add SPDX-License-Identifier to all source files
Change-Id: I9f2bc8c5d8a2c0bb0dd6caa4de5e2cb11be210e7
commit 513c8f4472886e6367c2ad66f9bac176d812cfa2
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-11-13 01:03:37 +0900
debian/copyright: fix upstream-name
Change-Id: Ia7b07524f9c3e6013992ee4ba5151d951b7d9eda
commit e2d33bf02d66032648a023aa570e03e4d6ad7179
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2017-11-01 00:44:19 +0100
vty: skip installing cmds now always installed by default
vty_install_default() and install_default() will soon be deprecated.
Depends: I5021c64a787b63314e0f2f1cba0b8fc7bff4f09b
Change-Id: I7771131a27d0b7ad0397715ceb3be035062bc010
commit d3c81da3985c87ca37f8dc4202838dd12879658b
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2017-10-27 22:49:59 +0200
jenkins: use osmo-clean-workspace.sh before and after build
See osmo-ci change I2409b2928b4d7ebbd6c005097d4ad7337307dd93 for rationale.
Depends: I2409b2928b4d7ebbd6c005097d4ad7337307dd93
Change-Id: I2f4c0a6b9a066160707eb7768ea9cc8b77806b9b
commit 4200aa6b696e0661b48e8880e07273351e5b3648
Author: Alexander Couzens <lynxis@fe80.eu>
Date: 2017-10-11 07:05:46 +0200
debian/rules: show testsuite.log when tests are failing
Change-Id: Ic3322e3931612f2153797331b02f2789490e5e2b
commit 01543a1ea392fa98974ea2f99cafbc28e9966656
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: 2017-09-14 04:32:19 +0200
cosmetic: ipa.c: use msgb_dequeue(), drop local var
Make ipa_server_conn_write() a lot simpler and shorter by using msgb_dequeue()
and avoiding local pointer that was used only once.
Change-Id: Id968e60d081a6d69de482a908ca3fe5e1044aaa3
commit d3292913ac99b4a57094ca19fd70571ec6914f48
Author: Max <msuraev@sysmocom.de>
Date: 2017-08-25 17:22:29 +0200
Use value string check from osmo-ci
Change-Id: I60d480ce6fb761ac8e15318dbe2c591359a51c3c
commit 7f17b8c45d094941292036143f3292a1d5789cf5
Author: Max <msuraev@sysmocom.de>
Date: 2017-08-25 16:09:48 +0200
Bump version: 0.3.2 → 0.4.0
Change-Id: Ibefe53a7f5b06fb8a9294574af41dacac68bdbe9
commit e3260722d7550dc13630307597c0df9075acd4af
Author: Max <msuraev@sysmocom.de>
Date: 2017-07-05 15:08:39 +0200
Use release helper from libosmocore
Change-Id: Ifc88e5c942a8b430b2436d429c86560d82984a95
Related: OS#1861
commit 35003ec2ea7de49d67e5332938a66fe92580b94d
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-07-05 22:04:43 +0200
contrib: Enable -Werror by default
Change-Id: I065b18dd6c4f7616f981aa4273e68e23825a7294
commit 1307b7aa606b31a54d6abbb3cf39c07ccf4d2cd0
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-07-13 22:14:37 +0200
configure.ac: Fix RTP_SIGNAL_PTR_CAST config in FreeBSD build
Move function definition to the first argument of AC_LANG_PROGRAM
(prologue) instead of the second (body). Content of the body is writen
into the main() function of the file being compiled, while prologue is
writen before it.
Compiler from FreeBSD build host doesn't like definitions inside the
main function, it fails with the following error:
conftest.c:28:73: error: function definition is not allowed here
As the compilation test fails, unsigned int is used instead of void*, which
doesn't match the current headers in the current build, and then a
warning (or error with -Werror) is printed.
Change-Id: I83fc3997e5067b499bf43cea4ff953604d6cbeae
commit ff8eed24e769800c1f7e946d64a3247cb1d4a9ae
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-07-12 00:38:25 +0200
check for missing result of rate_ctr_group_alloc()
In case the counter group allocation fails, we must handle this
gracefully and fail the allocation of the parent object, too.
Change-Id: Iff8506832d3472ab193b19b43cfbe7a9511075d1
Related: OS#2361
commit a06b877437a48ca14b8066663ea226dadee0014a
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-07-10 14:58:06 +0200
jenkins.sh: Proper error message if local environment isn't set up
Change-Id: Ibb34f07164adb175a44f460d02f54586b56a5b95
commit 65529bc54167cf2c1124fad59093e157a0c10d57
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-07-05 22:02:53 +0200
configure.ac: Fix C(PP)FLAGS for BSD build
Issue first found in libosmocore. It seems the BSD build doesn't use
bash which means using += to append to a variable doesn't work
correctly.
Change-Id: Id509351104bc7466114d4b9be450814254110f44
commit 9e992c24357dc19e6b0044584c553e802e0aebd1
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-06-29 18:04:18 +0200
osmo_ortp.c: Duration of a RTP frame affects timestamp of the next one
Duration of an RTP frames dictates the timestamp used for the next
frame, not for the one being sent now. It was done like this before to
account for possible losses.
Implementation wise, the duration was understood as "duration
between last frame was sent and now when current one is sent". It makes
more sense to use it as the duration in number of sampling ticks
as described on the function documentation, specially now that we can
account for extra time by means of osmo_rtp_skipped_frame.
Change-Id: Ib8f5fa5509059fe908c09a4381844c613d478548
commit 524923a96a9892445234248623d8be642eb5229d
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-06-28 15:31:46 +0200
osmo_ortp: Add osmo_rtp_drop_frame API
This API will be used by osmo-bts to maintain the sampling clock of the
RTP socket whenever a frame should be sent but it is not available, for
instance due to low quality of signal.
Change-Id: Id6099372b6231c0a4b6ea0716f46f5daee7049e1
commit c633cfbb9115485f3f54efe49480f4e2cec1cfa4
Author: Neels Hofmeyr <nhofmeyr@sysmocom.de>
Date: 2017-06-22 18:44:45 +0000
Revert "configure.ac: Use -Werror in C(PP)FLAGS"
As discussed in chat, -Werror should not be enabled by default.
Instead it should be added in our jenkins build scripts.
This reverts commit 7d1f53143e8eaeb25bae8979fb80dac57ddbf827.
Change-Id: Ied6e21b72b24fcb623fd945ed9560b742a8eedf5
commit 7d1f53143e8eaeb25bae8979fb80dac57ddbf827
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-06-21 07:44:28 +0200
configure.ac: Use -Werror in C(PP)FLAGS
Change-Id: Ic674bf28d781b9806dc023777e1fea4ee1a0257a
commit 62eddcdcd8c83c188e4f4b25367b0aa4cb57973d
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-06-21 07:43:14 +0200
configure.ac: Use -Wall in C(PP)FLAGS
Change-Id: I5033387e4a4206f7d34d1db3c6ede9255d199941
commit 05df2d65a715fa3f117e8f11b99a9533b96b4c73
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-06-21 07:37:45 +0200
osmo_ortp.c: Fix warning: check ortp API in rtp_session_signal_connect
Since ortp commit 5ab29c50adc7948b11449e3aeee66010379ff7dc preceeding
ortp 0.24, the API is fixed and requests a pointer instead of an
unsigned long.
As we now require at least ortp 0.22 since libosmo-abis
15d9b7929d449e4138bcb003c614035bceadc3d1, we need to support both old
and new version of the API to continue having support for 0.22 but still
supporting new versions of the library.
Change-Id: I2dbd0498d75160358eca4336850e1a0ad2efdbeb
commit b0c3a4a30f580d591e86774627cb79876610d165
Author: Pau Espin Pedrol <pespin@sysmocom.de>
Date: 2017-06-21 07:25:18 +0200
osmo_ortp.c: Fix warning: implicit use of function
Explicitly state that we are using an internal API from ortp, and
define the function we are using to avoid printing a warning.
Change-Id: I9cadcb31ce7ade3632d83753be97fdc9ea518b5b
commit b26f2fd8253a6e554f6ab7b6b0d48df197836555
Author: Pablo Neira Ayuso <pablo@gnumonks.org>
Date: 2017-06-07 18:32:13 +0200
src: use osmo_timer_setup()
Use new function available in libosmocore to set up timers. Compile
tested only.
Change-Id: I4ca4950e49a09c63b608b13ac7561ebbd351889a
commit e416e2e09d50390f79bcd284e6e91cd87fc8344e
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-05-26 13:11:59 +0200
Revert "ipacces.c: Remove ipa_bts_id_resp() and use libosmocore"
This reverts commit d517db06ced45bbe0a70799487964e52edd8a375, which for
some reason broke the IPA client functionality. This needs to be
investigated and properly fixed. But until that happens: revert.
Change-Id: Ic168f437c5bf1fcdb7441b0541c80a4805463004
commit cac78fe9e95d8f7f9eea07f99b910409e10854bc
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-05-25 19:13:13 +0200
Add value_string for input signal names (e1inp_signal_names)
Change-Id: I1662d4a969d2d12677646f3120b25be9a20c6d22
commit d517db06ced45bbe0a70799487964e52edd8a375
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-04-15 19:12:01 +0200
ipacces.c: Remove ipa_bts_id_resp() and use libosmocore
In Chanage-Id Icbcd8827a75fd5f3393351c1ca372de85275ad35 we introduced a
very similar function to libosocore. Let's use that rather than our own
version here.
Change-Id: I858920db1fb5f5d66e71b676d28c84d330d7904a
commit bf7976c0b0076410ad1bd67061dd18d0f33a7f43
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-04-04 12:10:54 +0000
Fix HAVE_ORTP_LOG_DOMAIN detection on FreeBSD
We need to use the include path[s] resolved by pkg-config for
ortp before trying to compile our test program. Without this
patch, compilation will fail e.g. on FreeBSD 11.
Change-Id: I0c95e37cc449297389bf31dd9d5dcaa922d75d0c
commit 5e87fdfcabc9cabe0025d7350b7ab31cdc4b6fa3
Author: Jean-Francois Dionne <jf.dionne@nutaq.com>
Date: 2017-03-06 13:22:37 -0500
Fix RTP jitter buffer that never stop to increase.
Duration passed to osmo_rtp_send_frame_ext function is based
on the last frame and the current one. Duration must then be
added to the timestamp before being transmitted.
Change-Id: I0593d6530c097cca34125a0ae2dd1b019b4dd80d
commit c42bf19cc5ebb7b675fc14b57a8e3946cbeb5e60
Author: Pau Espin Pedrol <pespin.shar@gmail.com>
Date: 2017-03-24 17:26:49 +0100
configure: Fix compilation with new libortp
Commit 0c8d9ddaea8c1afdc0e9b8c37a31c9d158e57efd in ortp broke old API:
function ortp_set_log_level_mask requires one new parameter 'domain'.
This commit fixes compilation in my Archlinux box using ortp 1.0.1.
Change-Id: I46e565f1873c7baf3c3b0aafe73951d20ce083b4
commit 1e04d4b7a2c845589da20d891cc5e3c471cfe983
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-03-18 17:56:03 +0100
README.md: Use <> around all hyperlinks to render them as links in cgit
Change-Id: I4b1004d5275972249d463083e0c2af41dc46dad2
commit 3fdb287d6564c7bf52c8d86137c699be894ea1d3
Author: Neels Hofmeyr <nhofmeyr@sysmocom.de>
Date: 2017-03-01 15:36:24 +0100
jenkins: add value_string termination check
Change-Id: I37c14c1a18207f64aa5e15ec0d2503bc834b2627
Depends: libosmocore change-id I2bc93ab4781487e7685cfb63091a489cd126b1a8
commit 7861ebac8493ee4ef9f3ccf8ea22918e1caab053
Author: Harald Welte <laforge@gnumonks.org>
Date: 2017-03-16 15:36:19 +0100
Add README file to libosmo-abis repository
Change-Id: I76ced414b22637792389fcf79ae6c7159502259b
commit 027e11936385a38bd331ea29f4f47a7b443c0932
Author: Philipp Maier <pmaier@sysmocom.de>
Date: 2016-12-08 17:17:33 +0100
lapd: log pointer addresses
Add pointer address output to the sap alloc/free functions in
order to track the objects later in the debug output (we have three
of them)
Change-Id: I9b961d5e36967cfd953551b24696849541257a1c
commit d75bac40d1b51a702cd14b35add6ff51d38d3994
Author: Philipp Maier <pmaier@sysmocom.de>
Date: 2017-02-01 13:51:03 +0100
lapd: Reduce N200 (SABM retransmission count)
N200, which controls the maxium number of LAPD retransmissions,
is set to 300. This will cause a long waiting time until
LAPD detects a failed link. This commit reduces the retransmission
count to 50 in order to get a faster link re-establishment in
case of link failure. This patch will only affect the ericsson
LAPD profile, all other lapd profiles will not be touched.
Change-Id: I4f56f9d00520adc0c0a4497547762cd054030867
commit beb10ef02a10d73537a97f6f21aad36664c9b266
Author: Alexander Couzens <lynxis@fe80.eu>
Date: 2016-11-01 22:05:13 +0100
add basic unixsocket support
Allow to connect to a unix socket for communicating with LAPD.
Change-Id: Ia5723b09a5c68a0505829dc732def981e60a907a
commit 8a3be282ab265a2587608e471b274dda200eae84
Author: Max <msuraev@sysmocom.de>
Date: 2017-02-20 18:24:03 +0100
Enable sanitize
Add ./configure option to enable ASAN checks and use it for jenkins
tests. While at it - also move to /bin/sh shebang as we don't use
bashisms anyway.
Change-Id: Ie26e54ab6b850c9adf124a6bc613ec9bc9e8a6e2
commit 254745880bb2ff7f17fe158fb7bfb5e1dc530906
Author: Holger Hans Peter Freyther <holger@moiji-mobile.com>
Date: 2017-01-23 19:49:07 +0100
misc: Fix build failure/warning when building on alpine linux
alpine linux is using the musl libc and this triggered some minor
compilation issues. Remove unused mISDN include and defines from
the general E1 input handling and address the other warnings and
errors.
/usr/include/sys/fcntl.h:1:2: warning: #warning redirecting incorrect #include <sys/fcntl.h> to <fcntl.h> [-Wcpp]
#warning redirecting incorrect #include <sys/fcntl.h> to <fcntl.h>
^~~~~~~
In file included from input/misdn.c:48:0:
../include/mISDNif.h:286:2: error: unknown type name 'u_int'
u_int id;
^~~~~
Change-Id: I997e45a456faedb5f370fd02ded300c1e36b791b
commit 30ffa7ade5aa55e95cf888bbdd9028f2983d663c
Author: Neels Hofmeyr <nhofmeyr@sysmocom.de>
Date: 2017-01-11 00:42:46 +0100
undup: subchan_demux.c: use libosmocore's llist_count()
Depends on libosmocore Change-Id Ic49adc7a346f5722bf624d7d3b4a735e4220ae15
Change-Id: I47f1831f1835dc07925dabbc115677087e48fa1b
commit c9fa25e8316b8af3e9f11b9e79368092df466972
Author: Max <msuraev@sysmocom.de>
Date: 2017-01-09 13:23:15 +0100
handle_ts1_read(): log sign_link() error
Change-Id: I95779ee8590ab16b7af4ad2c79ede68da3a12e5a
commit 4c4a1c2035cd884d300fc0a04cb9995b16eade62
Author: Max <msuraev@sysmocom.de>
Date: 2016-12-30 15:10:47 +0100
ipaccess_line_update(): log connection IP addresses and ports
Remove dup: call function to obtain IPA address only once. Log
explicitly IP address and ports to which IPA is bound or connected.
Change-Id: I841c40abdcba0fdd695a43231391c5d7cee20fae
commit efb43c012ba95fc9373704ade7b583dffb46b621
Author: Max <msuraev@sysmocom.de>
Date: 2016-12-21 14:24:29 +0100
Add gerrit settings
Make it simple to setup and use this repo with 'git review' command.
Change-Id: I04aeee90641555df19e969f925474ec6f9a23354
commit 5f3871e3626a407c01af42d72a9e8ea010938dc2
Author: Max <msuraev@sysmocom.de>
Date: 2016-12-21 14:18:34 +0100
Integrate Debian packaging changes
debian/control:
* restructure to make it easier to incorporate further changes
* update package descriptions
* update project URL
debian/rules:
* use proper hardening syntax
* restructure to make it easier to incorporate further changes
* add cleanup override
debian/copyright: add file matching Debian format
Change-Id: I6af8ab7f5c75b4d161cebf492f3de5d9dbd00220
Related: OS#1694
commit bf42e0a91fcf79efa9b68c38568021e4d68c87b2
Author: Max <msuraev@sysmocom.de>
Date: 2016-12-15 19:57:57 +0100
Enable adaptive jitter compensation
* check RTP socket parameter and enable necessary jitter buffering
* return the status of requested jitter buffering instead of always
returning 0
* document function parameters and return value
Change-Id: I87d4d9fe990683adbb02b64cb39b78de533d8046
commit ac2ad3b437bd20a766daed0cb668e394a0a2bc4e
Author: Max <msuraev@sysmocom.de>
Date: 2016-12-16 12:19:21 +0100
Remove obsolete compile-time conditional
Change-Id: If8f87587227b09635361b758873f75d8b6aa3497
commit 7c840be4765700e6a6efc54ddbbff4c279f91cca
Author: Max <msuraev@sysmocom.de>
Date: 2016-12-05 16:13:53 +0100
Expand network error callback
ortp: use extra parameter for network_error callback in log message as
it's described in oRTP documentation (error string).
Change-Id: I581db499d453b80230198d95000f0f6fc20752d1
commit 78d0486ffdbb404c01315f28b24ef0688a57a99b
Author: Max <msuraev@sysmocom.de>
Date: 2016-12-05 16:02:52 +0100
osmo_rtp_socket_poll(): Fix log message to match function name
Change-Id: I5c36bbc35e2ba794b5e446f52a0752bcf1367d11
commit b0a4235805a690ddad47d890e183b29c03322515
Author: Harald Welte <laforge@gnumonks.org>
Date: 2016-11-26 09:44:33 +0100
don't pass negative error to strerror()
Change-Id: I48c25c78148d1fe9ce4e4a88cdfe5cf74dc95b17
Fixes: Coverity CID 57858
commit 519217f0eafee4fe71c49e5310c6f26621f0a6e1
Author: Harald Welte <laforge@gnumonks.org>
Date: 2016-11-26 09:43:46 +0100
call strerror() not on negative value
Change-Id: I0ba1eab49f93d9b34d162682f2528d106b56d6d6
Fixes: Coverity CID 57857
commit 14dd30a13e27afcbdc7cce7203d07b50de48fa53
Author: Harald Welte <laforge@gnumonks.org>
Date: 2016-11-26 09:37:09 +0100
fix signed/unsigned bug in ipa_client_conn_open()
If osmo_sock_init() would ever return a negative FD together with
errno == EINPROGRESS, we would have attempted to register that negative
FD with the select() main loop handling, whihc of course doesn't work.
EINPROGRESS for a non-blocking connecting socket is handled inside
osmo_sock_init() and would result in it returning a positive FD, so the
above case is of theoretical significance only.
Change-Id: Id01eb0d48eea6cab1fbc720c52361101b8ea4e35
Fixes: Coverity CID 57856
commit 34260c892390c6831a0a5fb906bc3bffcfd08896
Author: Harald Welte <laforge@gnumonks.org>
Date: 2016-11-26 09:27:04 +0100
osmo_rtp_socket_fdreg(): Check return value of osmo_fd_register()
Change-Id: I4969e0a9e7109d426066e6c2b80ed44c396b65b5
Fixes: Coverity CID 57631
commit ae3a993bd637b3994db0183abe8cfc6eeb796d51
Author: Harald Welte <laforge@gnumonks.org>
Date: 2016-11-26 09:25:23 +0100
input/ipaccess.c: Check return value of osmo_fd_register()
Change-Id: I81659e0533ceb5d43292d97a63300b500044add7
Fixes: Coverity CID 57630
commit 35daa67763b53790edecd8329d4012b9b1ed436f
Author: Alexander Couzens <lynxis@fe80.eu>
Date: 2016-11-08 16:17:20 +0100
e1_input: remove superflous semi colon
Change-Id: I7e9079cbac1d9920da2aace35810682b49ec532f
commit ab3b5606fe02cd87241e9992cfe232eed07033f9
Author: Harald Welte <laforge@gnumonks.org>
Date: 2016-11-16 11:02:25 +0100
lapd_pcap.h: Add missing #include lines
we reference 'struct msgb' and mode_t, so we have to #include
the right header files.
Change-Id: Iac8f905182b60782202bdf75e04d47ea89dc3863
...